Skip to content

Commit 0c83240

Browse files
olcbeanChristoph Büscher
authored andcommitted
Java Api clean up: remove deprecated isShardsAcked (#28311)
This PR removes previously deprecated `isShardsAcked()` method in favour of `isShardsAcknowledged()` on `CreateIndexResponse`, `CreateIndexClusterStateUpdateResponse` and `RolloverResponse` Related to #27784 Follow-up of #27819
1 parent 261fb6a commit 0c83240

File tree

5 files changed

+10
-31
lines changed

5 files changed

+10
-31
lines changed

docs/reference/migration/migrate_7_0.asciidoc

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -31,6 +31,7 @@ Elasticsearch 6.x in order to be readable by Elasticsearch 7.x.
3131
* <<breaking_70_plugins_changes>>
3232
* <<breaking_70_analysis_changes>>
3333
* <<breaking_70_api_changes>>
34+
* <<breaking_70_java_changes>>
3435

3536

3637
include::migrate_7_0/aggregations.asciidoc[]
@@ -41,3 +42,4 @@ include::migrate_7_0/mappings.asciidoc[]
4142
include::migrate_7_0/search.asciidoc[]
4243
include::migrate_7_0/plugins.asciidoc[]
4344
include::migrate_7_0/api.asciidoc[]
45+
include::migrate_7_0/java.asciidoc[]
Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,8 @@
1+
[[breaking_70_java_changes]]
2+
=== Java API changes
3+
4+
==== `isShardsAcked` deprecated in `6.2` has been removed
5+
6+
`isShardsAcked` has been replaced by `isShardsAcknowledged` in
7+
`CreateIndexResponse`, `RolloverResponse` and
8+
`CreateIndexClusterStateUpdateResponse`.

server/src/main/java/org/elasticsearch/action/admin/indices/create/CreateIndexResponse.java

Lines changed: 0 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -85,18 +85,6 @@ public void writeTo(StreamOutput out) throws IOException {
8585
}
8686
}
8787

88-
/**
89-
* Returns true if the requisite number of shards were started before
90-
* returning from the index creation operation. If {@link #isAcknowledged()}
91-
* is false, then this also returns false.
92-
*
93-
* @deprecated use {@link #isShardsAcknowledged()}
94-
*/
95-
@Deprecated
96-
public boolean isShardsAcked() {
97-
return shardsAcknowledged;
98-
}
99-
10088
/**
10189
* Returns true if the requisite number of shards were started before
10290
* returning from the index creation operation. If {@link #isAcknowledged()}

server/src/main/java/org/elasticsearch/action/admin/indices/rollover/RolloverResponse.java

Lines changed: 0 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -111,18 +111,6 @@ public boolean isAcknowledged() {
111111
return acknowledged;
112112
}
113113

114-
/**
115-
* Returns true if the requisite number of shards were started in the newly
116-
* created rollover index before returning. If {@link #isAcknowledged()} is
117-
* false, then this will also return false.
118-
*
119-
* @deprecated use {@link #isShardsAcknowledged()}
120-
*/
121-
@Deprecated
122-
public boolean isShardsAcked() {
123-
return shardsAcknowledged;
124-
}
125-
126114
/**
127115
* Returns true if the requisite number of shards were started in the newly
128116
* created rollover index before returning. If {@link #isAcknowledged()} is

server/src/main/java/org/elasticsearch/cluster/ack/CreateIndexClusterStateUpdateResponse.java

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -33,14 +33,7 @@ public CreateIndexClusterStateUpdateResponse(boolean acknowledged, boolean shard
3333

3434
/**
3535
* Returns whether the requisite number of shard copies started before the completion of the operation.
36-
*
37-
* @deprecated use {@link #isShardsAcknowledged()}
3836
*/
39-
@Deprecated
40-
public boolean isShardsAcked() {
41-
return shardsAcknowledged;
42-
}
43-
4437
public boolean isShardsAcknowledged() {
4538
return shardsAcknowledged;
4639
}

0 commit comments

Comments
 (0)