Add created_date and modified_date to entities#5097
Merged
Conversation
Contributor
|
Following you can find the validation changes against the target branch for the APIs.
You can validate these APIs yourself by using the |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds system-managed timestamp properties (created_date, created_date_millis, modified_date, and modified_date_millis) to three Elasticsearch entity types: ingest pipelines, component templates, and index templates. These properties provide creation and modification tracking for better entity management.
- Introduces a new
DateStringtype for ISO 8601 formatted date strings - Adds four timestamp fields to Pipeline, ComponentTemplateNode, and IndexTemplate classes
- Updates example responses to include the new timestamp properties
Reviewed Changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
specification/_types/Time.ts |
Introduces DateString type and refactors DateTime to use it |
specification/ingest/_types/Pipeline.ts |
Adds timestamp fields to Pipeline class with availability annotations |
specification/cluster/_types/ComponentTemplate.ts |
Adds timestamp fields to ComponentTemplateNode class |
specification/indices/_types/IndexTemplate.ts |
Adds timestamp fields to IndexTemplate class |
| Example YAML files | Updates response examples to include new timestamp properties |
| Generated output files | Auto-generated updates to TypeScript, JSON schema, and OpenAPI specs |
Comments suppressed due to low confidence (2)
specification/cluster/get_component_template/examples/200_response/GetComponentTemplateResponseExample1.yaml:14
- The dates are inconsistent - created_date is 2024-01-01 but modified_date is 2025-01-01, which means the entity was modified before it was created. The created_date should be earlier than or equal to the modified_date.
\ \"created_date_millis\" : 1704110400000,\n \"modified_date\" : \"2025-01-01T12:00:00.000Z\",\n\
specification/indices/get_index_template/examples/200_response/GetIndexTemplateResponseExample1.yaml:15
- The dates are inconsistent - created_date is 2024-01-01 but modified_date is 2025-01-01, which means the entity was modified before it was created. The created_date should be earlier than or equal to the modified_date.
\ \"description\" : \"my custom index template\"\n },\n \"created_date\" : \"2024-01-01T12:00:00.000Z\",\n\
* origin/main: [DOCS] Fix typos in the shared overlays file (#5124) Update specification output Remove unused EIS types (#5107) No native utility types validation lint (#4567) Document reindexing failures (#5031) Add dangling types to validation-errors.json (#5106) Update specification output Change `KeyedPercentiles` value type from `long` to `double` (#5108) [DOCS]: Add descriptions to API tags (#5098) Bump form-data and @redocly/cli in /docs/examples (#5074) Update specification output Adds cat-h values (#5096) Bump @eslint/plugin-kit from 0.3.3 to 0.3.4 in /specification (#5053) Update specification output [DOCS] Adds Ruby bulk helper to BulkRequest documentation (#5057)
andrewkroh
added a commit
to andrewkroh/go-ingest-node
that referenced
this pull request
Aug 15, 2025
Include a note on handling generic type parameters to improve type generation. Relates: elastic/elasticsearch-specification#5097
andrewkroh
added a commit
to andrewkroh/go-ingest-node
that referenced
this pull request
Aug 15, 2025
Include a note on handling generic type parameters to improve type generation. Relates: elastic/elasticsearch-specification#5097
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
adding new system-managed properties to ingest pipelines, component templates and index templates
relates to:
{created,modified}_dateelasticsearch#131536created_dateandmodified_dateelasticsearch#130847created_dateandmodified_datemetadata for index templates, component templates and ingest pipelines elasticsearch#108754