[Client] Updates elasticsearch tests for APIs with required body

Author: picandocodigo

elasticsearch/spec/unit/elasticsearch_product_validation_spec.rb

@@ -21,11 +21,11 @@
 describe 'Elasticsearch: Validation' do
   let(:host) { 'http://localhost:9200' }
   let(:count_request_stub) do
-    stub_request(:get, "#{host}/_count")
-      .to_return(status: status, body: nil, headers: headers)
+    stub_request(:post, "#{host}/_count")
+      .to_return(status: status, body: '', headers: headers)
   end
   let(:status) { 200 }
-  let(:body) { nil }
+  let(:body) { '' }
   let(:headers) { {} }
   let(:client) { Elasticsearch::Client.new }
 
@@ -39,7 +39,7 @@
       expect(client.instance_variable_get('@verified')).to be false
       count_request_stub
       expect do
-        client.count
+        client.count(body: '')
       end.to raise_error Elastic::Transport::Transport::Errors::Unauthorized
       expect(client.instance_variable_get('@verified')).to be true
 
@@ -61,7 +61,7 @@
       expect(client.instance_variable_get('@verified')).to be false
       count_request_stub
       expect do
-        client.count
+        client.count(body: '')
       end.to raise_error Elastic::Transport::Transport::Errors::Forbidden
       expect(client.instance_variable_get('@verified')).to be true
 
@@ -83,7 +83,7 @@
       expect(client.instance_variable_get('@verified')).to be false
       count_request_stub
       expect do
-        client.count
+        client.count(body: '')
       end.to raise_error Elastic::Transport::Transport::Errors::RequestEntityTooLarge
       expect(client.instance_variable_get('@verified')).to be true
 
@@ -107,7 +107,7 @@
       expect(client.instance_variable_get('@verified')).to be false
       count_request_stub
       expect do
-        client.count
+        client.count(body: '')
       end.to raise_error Elastic::Transport::Transport::Errors::ServiceUnavailable
       expect(client.instance_variable_get('@verified')).to be false
 
@@ -131,7 +131,7 @@
     it 'Makes requests and passes validation' do
       expect(client.instance_variable_get('@verified')).to be false
       count_request_stub
-      client.count
+      client.count(body: '')
       expect(client.instance_variable_get('@verified')).to be true
     end
   end

elasticsearch/spec/unit/headers_spec.rb

@@ -24,9 +24,9 @@
 
     it 'performs the request with the header' do
       allow(client).to receive(:perform_request) { OpenStruct.new(body: '') }
-      expect { client.search(headers: headers) }.not_to raise_error
+      expect { client.search(headers: headers, body: '') }.not_to raise_error
       expect(client).to have_received(:perform_request)
-        .with('GET', '_search', {}, nil, headers, { endpoint: 'search' })
+        .with('POST', '_search', {}, '', headers, { endpoint: 'search' })
     end
   end
 
@@ -47,9 +47,9 @@
 
       expect_any_instance_of(Faraday::Connection)
         .to receive(:run_request)
-          .with(:get, 'http://localhost:9200/_search', nil, expected_headers) { OpenStruct.new(body: '') }
+          .with(:post, 'http://localhost:9200/_search', '', expected_headers) { OpenStruct.new(body: '') }
 
-      client.search(headers: param_headers)
+      client.search(headers: param_headers, body: '')
     end
   end
 
@@ -73,8 +73,8 @@
 
       expect_any_instance_of(Faraday::Connection)
         .to receive(:run_request)
-              .with(:get, 'http://localhost:9200/_search', nil, connection_headers) { OpenStruct.new(body: '') }
-      client.search
+              .with(:post, 'http://localhost:9200/_search', '', connection_headers) { OpenStruct.new(body: '') }
+      client.search(body: '')
     end
   end
 
@@ -98,8 +98,8 @@
 
       expect_any_instance_of(Faraday::Connection)
         .to receive(:run_request)
-              .with(:get, 'http://localhost:9200/_search', nil, connection_headers) { OpenStruct.new(body: '') }
-      client.search
+              .with(:post, 'http://localhost:9200/_search', '', connection_headers) { OpenStruct.new(body: '') }
+      client.search(body: '')
     end
   end
 
@@ -117,8 +117,8 @@
 
       expect_any_instance_of(Faraday::Connection)
         .to receive(:run_request)
-              .with(:get, 'http://localhost:9200/_search', nil, expected_headers) { OpenStruct.new(body: '') }
-      client.search
+              .with(:post, 'http://localhost:9200/_search', '', expected_headers) { OpenStruct.new(body: '') }
+      client.search(body: '')
     end
   end
 end

elasticsearch/spec/unit/opaque_id_spec.rb

@@ -27,9 +27,9 @@
 
   context 'when x-opaque-id is set' do
     it 'uses x-opaque-id on a request' do
-      client.search(opaque_id: '12345')
+      client.search(opaque_id: '12345', body: '')
       expect(transport).to have_received(:perform_request)
-        .with('GET', '_search', {}, nil, { 'X-Opaque-Id' => '12345' }, {:endpoint=>"search"})
+        .with('POST', '_search', {}, '', { 'X-Opaque-Id' => '12345' }, {:endpoint=>"search"})
     end
   end
 
@@ -40,9 +40,9 @@
     end
 
     it 'uses x-opaque-id on a request' do
-      expect { client.search(opaque_id: '12345') }.not_to raise_error
+      expect { client.search(opaque_id: '12345', body: '') }.not_to raise_error
       expect(transport).to have_received(:perform_request)
-        .with('GET', '_search', {}, nil, { 'X-Opaque-Id' => 'elastic_cloud12345' }, {:endpoint=>"search"})
+        .with('POST', '_search', {}, '', { 'X-Opaque-Id' => 'elastic_cloud12345' }, {:endpoint=>"search"})
     end
   end
 end