Do not set HttpRequestMessage content when no PostData #3925
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit changes the HttpConnection to not set Content on HttpRequestMessage when there is no PostData. The check is performed inside of Request and RequestAsync to avoid creating any content instance and allocations. Change length to default in TryComputeLength to match HttpContent implementation. Pass RequestData through to _onStreamAvailable delegates so that HttpCompression, ConnectionSettings and PostData can be accessed on the passed instance. Fixes #3907
Mpdreamz
requested changes
Jul 5, 2019
Member
Mpdreamz
left a comment
Mpdreamz
left a comment
There was a problem hiding this comment.
I left some comments on changes made that differ from the reference implementations RequestDataContent is based on.
| { | ||
| // We can't know the length of the content being pushed to the output stream. | ||
| length = -1; | ||
| length = default; |
Member
There was a problem hiding this comment.
-1 was taken from: https://github.com/aspnet/AspNetWebStack/blob/master/src/System.Net.Http.Formatting/PushStreamContent.cs#L128
which RequestDataContent is modeled after
| public override void Close() | ||
| { | ||
| _serializeToStreamTask.TrySetResult(true); | ||
| base.Close(); |
Member
There was a problem hiding this comment.
We don't call close here because PushStreamContent does not either
|
|
||
| public override void WriteByte(byte value) => _innerStream.WriteByte(value); | ||
|
|
||
| public override void Close() => _innerStream.Close(); |
Member
There was a problem hiding this comment.
Does not implement this, I think its good to have though.
| [I] | ||
| public void NotUsingSocketsHttpHandlerDoesNotCauseException() | ||
| { | ||
| AppContext.SetSwitch("System.Net.Http.UseSocketsHttpHandler", false); |
Member
There was a problem hiding this comment.
Add comment this is safe to do because IntrusiveOperationCluster runs with max concurrency of 1
codebrain
approved these changes
Jul 8, 2019
Contributor
codebrain
left a comment
codebrain
left a comment
There was a problem hiding this comment.
Reviewed via Zoom, approved with changes
russcam
added a commit
that referenced
this pull request
Jul 8, 2019
This commit changes the HttpConnection to not set Content on HttpRequestMessage when there is no PostData. The check is performed inside of Request and RequestAsync to avoid creating any content instance and allocations. Pass RequestData through to _onStreamAvailable delegates so that HttpCompression, ConnectionSettings and PostData can be accessed on the passed instance. Fixes #3907 (cherry picked from commit 90c2bf7)
russcam
added a commit
that referenced
this pull request
Jul 18, 2019
This commit changes the HttpConnection to not set Content on HttpRequestMessage when there is no PostData. The check is performed inside of Request and RequestAsync to avoid creating any content instance and allocations. Pass RequestData through to _onStreamAvailable delegates so that HttpCompression, ConnectionSettings and PostData can be accessed on the passed instance. Fixes #3907 (cherry picked from commit 90c2bf7)
codebrain
pushed a commit
that referenced
this pull request
Jul 19, 2019
This commit changes the HttpConnection to not set Content on HttpRequestMessage when there is no PostData. The check is performed inside of Request and RequestAsync to avoid creating any content instance and allocations. Pass RequestData through to _onStreamAvailable delegates so that HttpCompression, ConnectionSettings and PostData can be accessed on the passed instance. Fixes #3907 (cherry picked from commit 90c2bf7)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit changes the HttpConnection to not set Content on HttpRequestMessage when there is no PostData. The check is performed inside of Request and RequestAsync to avoid creating any content instance and allocations.
Change length to default in TryComputeLength to match HttpContent implementation.
Pass RequestData through to _onStreamAvailable delegates so that HttpCompression, ConnectionSettings and PostData can be accessed on the passed instance.
Fixes #3907