Return default when no bytes read from response streaming-no-response… #3882
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-body This commit returns default(T) when no bytes are read from the response stream. Move the stream null and seek check into JsonSerializer. Update index exists integration test to not disable direct streaming in order to test.
codebrain
approved these changes
Jun 27, 2019
|
|
||
| namespace Tests.Core.ManagedElasticsearch.Clusters | ||
| { | ||
| public class DirectStreamingReadOnlyCluster : ClientTestClusterBase |
Contributor
There was a problem hiding this comment.
Seems a bit heavy handed, can we just override in the test?
(Although I can see a counter argument here that we may want to keep around for other tests).
| public static T Deserialize<T>(byte[] bytes, int offset, IJsonFormatterResolver resolver) | ||
| { | ||
| if (resolver == null) resolver = DefaultResolver; | ||
| if (bytes == null || bytes.Length == 0) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…-body
This commit returns default(T) when no bytes are read from the response stream. Move the stream null and seek check into JsonSerializer.
Update index exists integration test to not disable direct streaming in order to test.