refactor: simplify custom Kibana config to auto-detect file

- Remove configKibanaCustomConfigEnabled option
- Automatically detect kibana-custom.yml file existence
- Simplify setup - just create the file to enable custom config
- Update documentation to reflect simpler approach
- Maintain backward compatibility and all existing functionality

This makes the feature more discoverable and easier to use without
requiring users to enable it via configuration.

Author: ruflin

README.md

@@ -689,10 +689,13 @@ The following settings are available per profile:
 * `stack.elastic_subscription` allows to select the Elastic subscription type to be used in the stack.
   Currently, it is supported "basic" and "[trial](https://www.elastic.co/guide/en/elasticsearch/reference/current/start-trial.html)",
   which enables all subscription features for 30 days.  Defaults to "trial".
-* `stack.kibana_custom_config_enabled` can be set to true to enable custom Kibana configuration.
-  When enabled, you can create a `kibana-custom.yml` file in your profile directory with additional
-  Kibana settings that will be appended to the base configuration. Defaults to false.
-  See [Custom Kibana Configuration](docs/howto/custom_kibana_config.md) for details.
+
+## Custom Kibana Configuration
+
+You can provide custom Kibana configuration by creating a `kibana-custom.yml` file in your profile directory.
+The custom configuration will be automatically appended to the base configuration when the file exists.
+
+See [Custom Kibana Configuration](docs/howto/custom_kibana_config.md) for detailed instructions.
 
 ## Useful environment variables
 

docs/howto/custom_kibana_config.md

@@ -13,19 +13,13 @@ You can provide additional Kibana configuration that will be appended to the bas
 
 ## Setup
 
-1. Enable custom configuration in your profile:
-   ```bash
-   # Edit ~/.elastic-package/profiles/default/config.yml
-   stack.kibana_custom_config_enabled: true
-   ```
-
-2. Create your custom configuration file:
+1. Create your custom configuration file:
    ```bash
    # Create ~/.elastic-package/profiles/default/kibana-custom.yml
    touch ~/.elastic-package/profiles/default/kibana-custom.yml
    ```
 
-3. Add your custom configuration:
+2. Add your custom configuration:
    ```yaml
    # Example custom configuration
    logging.loggers:
@@ -142,9 +136,9 @@ monitoring.ui.container.elasticsearch.enabled: true
 ## Troubleshooting
 
 ### Configuration Not Applied
-- Ensure `stack.kibana_custom_config_enabled: true` is set in your profile's `config.yml`
 - Verify the `kibana-custom.yml` file exists in your profile directory
 - Check that the YAML syntax is valid
+- Ensure the file is in the correct location: `~/.elastic-package/profiles/{profile_name}/kibana-custom.yml`
 
 ### Template Errors
 - Use `{{ fact "variable_name" }}` syntax for template variables
@@ -168,7 +162,7 @@ You can have different custom configurations for different profiles:
 ~/.elastic-package/profiles/production/kibana-custom.yml
 ```
 
-Each profile can enable or disable custom configuration independently.
+Custom configuration is automatically detected and applied for each profile when the `kibana-custom.yml` file exists.
 
 ## Best Practices
 

internal/profile/_static/config.yml.example

@@ -29,7 +29,3 @@
 
 ## Set license subscription
 # stack.elastic_subscription: "basic"
-
-## Custom Kibana Configuration
-# Enable custom kibana.yml configuration file
-# stack.kibana_custom_config_enabled: true

internal/stack/kibana_config.go

@@ -33,11 +33,7 @@ func kibanaConfigWithCustomContent(profile *profile.Profile) func(resource.Conte
 			return fmt.Errorf("failed to write base kibana config: %w", err)
 		}
 
-		// Check if custom config is enabled and exists
-		if profile.Config(configKibanaCustomConfigEnabled, "false") == "false" {
-			return nil // No custom config needed
-		}
-
+		// Check if custom config file exists
 		customConfigPath := profile.Path(KibanaCustomConfigFile)
 		customConfigData, err := os.ReadFile(customConfigPath)
 		if os.IsNotExist(err) {

internal/stack/resources.go

@@ -61,14 +61,13 @@ const (
 	elasticsearchUsername = "elastic"
 	elasticsearchPassword = "changeme"
 
-	configAPMEnabled                = "stack.apm_enabled"
-	configGeoIPDir                  = "stack.geoip_dir"
-	configKibanaHTTP2Enabled        = "stack.kibana_http2_enabled"
-	configKibanaCustomConfigEnabled = "stack.kibana_custom_config_enabled"
-	configLogsDBEnabled             = "stack.logsdb_enabled"
-	configLogstashEnabled           = "stack.logstash_enabled"
-	configSelfMonitorEnabled        = "stack.self_monitor_enabled"
-	configElasticSubscription       = "stack.elastic_subscription"
+	configAPMEnabled          = "stack.apm_enabled"
+	configGeoIPDir            = "stack.geoip_dir"
+	configKibanaHTTP2Enabled  = "stack.kibana_http2_enabled"
+	configLogsDBEnabled       = "stack.logsdb_enabled"
+	configLogstashEnabled     = "stack.logstash_enabled"
+	configSelfMonitorEnabled  = "stack.self_monitor_enabled"
+	configElasticSubscription = "stack.elastic_subscription"
 )
 
 var (