-
Notifications
You must be signed in to change notification settings - Fork 129
feat(xy): collapsing time into a single hh:mm[:ss] layer #1791
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
buildkite update vrt |
|
Hi @monfera it looks great in my opinion. I'm wondering if we can add intermediate steps between the jumps, for example:
There could be a bit more raster to add, but can be considered to add a more "sparse" representation. |
|
@markov00 I think some or all the rasters can be added, but it'd be great to discuss and implement it in a next PR, as it's in my understanding, lower priority than, and separable from the merger of the layers:
|
|
@markov00 btw. I was planning to update the 3-layer stories to 2-layer stories in a separate PR too, so the effect of individual changes can be more incrementally assessed, but I can add it to this PR if you think it's better that way |
|
@monfera can we say that we are going to deprecate completely the 3 layers implementation? or do you like to keep that configuration and let the developers decide? |
|
@markov00 Yes I think it's best to switch from where it is 3 layers today to 2 layers, because the reason for the 3 layers was the rather granular layer labeling, which we consolidated with the layer collapse. You might want to circulate it among call sites and PMs, though it's not in the way of this specific PR, as layer count is externally specified |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks great to me.
I've added just one comment to check before merging
packages/charts/src/chart_types/xy_chart/axes/timeslip/rasters.ts
Outdated
Show resolved
Hide resolved
This PR fixes the problem caused by a wrongly generated React key on each grid items.
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Marco Vettorello <[email protected]>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
* fix(metric): clip title at right length * test(vrt): update screenshots [skip ci] Co-authored-by: elastic-datavis[bot] <98618603+elastic-datavis[bot]@users.noreply.github.com>
## [47.2.1](elastic/elastic-charts@v47.2.0...v47.2.1) (2022-08-23) ### Bug Fixes * **deps:** update dependency @elastic/eui to v63 ([elastic#1783](elastic#1783)) ([554f370](elastic@554f370)) * **deps:** update dependency @elastic/eui to v64 ([elastic#1798](elastic#1798)) ([bb028e9](elastic@bb028e9)) * **metric:** clip title at right length ([elastic#1790](elastic#1790)) ([7d7ad55](elastic@7d7ad55)) * **metric:** use a correct React key for each grid item ([elastic#1789](elastic#1789)) ([076406e](elastic@076406e))
# [48.0.0](v47.2.1...v48.0.0) (2022-08-31) ### Bug Fixes * **deps:** update dependency @elastic/eui to v65 ([#1802](#1802)) ([37a0ce7](37a0ce7)) * **deps:** upgrade uuid to latest version ([#1794](#1794)) ([35bb737](35bb737)) ### Features * **xy:** collapsing time into a single hh:mm[:ss] layer ([#1791](#1791)) ([577cfee](577cfee)) ### BREAKING CHANGES * **xy:** show hh:mm in a single labeled axis layer and other grid related adjustments
Summary
Details
Issues
Closes #1777
Checklist
:xy,:partition):interactions,:axis)closes #123,fixes #123)dark,light,eui-dark&eui-light