fix(specs): shows a chart message without series specified #506
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fix the use case when no series spec is configured. Instead of throwing an error, it will just display the "No data to display" message.
Codecov Report
@@ Coverage Diff @@
## master #506 +/- ##
==========================================
+ Coverage 84.56% 84.57% +0.01%
==========================================
Files 158 169 +11
Lines 4736 4889 +153
Branches 965 985 +20
==========================================
+ Hits 4005 4135 +130
- Misses 716 738 +22
- Partials 15 16 +1
Continue to review full report at Codecov.
|
nickofthyme
reviewed
Jan 2, 2020
rshen91
approved these changes
Jan 2, 2020
Contributor
rshen91
left a comment
rshen91
left a comment
There was a problem hiding this comment.
Thanks for adding the tests - these changes make sense!
markov00
pushed a commit
that referenced
this pull request
Jan 3, 2020
## [16.0.1](v16.0.0...v16.0.1) (2020-01-03) ### Bug Fixes * **specs:** shows a chart message without series specified ([#506](#506)) ([ba1a67b](ba1a67b))
Member
Author
|
🎉 This PR is included in version 16.0.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
4 tasks
AMoo-Miki
pushed a commit
to AMoo-Miki/OpenSearch-Dashboards
that referenced
this pull request
Feb 10, 2022
## [16.0.1](elastic/elastic-charts@v16.0.0...v16.0.1) (2020-01-03) ### Bug Fixes * **specs:** shows a chart message without series specified ([opensearch-project#506](elastic/elastic-charts#506)) ([4112e62](elastic/elastic-charts@4112e62))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This commit fix the use case when no series specs are configured. Instead of throwing an error, it
will just display the "No data to display" message.
Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.src/index.ts(and stories only import from../srcexcept for test data & storybook)