fix(highlighter): hide it when tooltip type is None #482
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the tooltip type is hidden (TooltipType.None) then the tooltip should not be shown. This add the check on the selector and includes also a smoke test. fix elastic#478
Codecov Report
@@ Coverage Diff @@
## master #482 +/- ##
==========================================
+ Coverage 83.76% 83.83% +0.06%
==========================================
Files 158 158
Lines 4706 4720 +14
Branches 953 960 +7
==========================================
+ Hits 3942 3957 +15
+ Misses 749 748 -1
Partials 15 15
Continue to review full report at Codecov.
|
nickofthyme
approved these changes
Dec 5, 2019
Collaborator
nickofthyme
left a comment
nickofthyme
left a comment
There was a problem hiding this comment.
Added the mergePartial changes you wanted.
Also looks like the ON_POINTER_MOVE action is still triggered. Would be nice to prevent that but that can be done some other time.
| export const DEFAULT_TOOLTIP_SNAP = true; | ||
|
|
||
| export const DEFAULT_SETTINGS_SPEC = { | ||
| export const DEFAULT_SETTINGS_SPEC: SettingsSpec = { |
nickofthyme
approved these changes
Dec 5, 2019
Member
Author
|
🎉 This PR is included in version 15.0.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
4 tasks
AMoo-Miki
pushed a commit
to AMoo-Miki/OpenSearch-Dashboards
that referenced
this pull request
Feb 10, 2022
## [15.0.3](elastic/elastic-charts@v15.0.2...v15.0.3) (2019-12-05) ### Bug Fixes * **highlighter:** hide it when tooltip type is None ([opensearch-project#482](elastic/elastic-charts#482)) ([f6de794](elastic/elastic-charts@f6de794)), closes [opensearch-project#478](elastic/elastic-charts#478) [opensearch-project#479](elastic/elastic-charts#479)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
If the tooltip type is hidden (TooltipType.None) then the tooltip should not be shown. This add the
check in the selector and includes also a smoke test for all tooltips.
side notes
there was already a test checking if the tooltip was visible or not, but it doesn't include a check if the highlighter was visible or not.
fix #478
Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.[ ] Any consumer-facing exports were added tosrc/index.ts(and stories only import from../srcexcept for test data & storybook)[ ] This was checked for cross-browser compatibility, including a check against IE11[ ] Proper documentation or storybook story was added for features that require explanation or tutorials