Skip to content

Commit ed6d0e5

Browse files
authored
fix: remove clippings from chart geometries (#320)
fix #20
1 parent cf00fd9 commit ed6d0e5

File tree

1 file changed

+4
-22
lines changed

1 file changed

+4
-22
lines changed

src/components/react_canvas/reactive_chart.tsx

Lines changed: 4 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -380,15 +380,6 @@ class Chart extends React.Component<ReactiveChartProps, ReactiveChartState> {
380380
</div>
381381
);
382382
}
383-
// disable clippings when debugging
384-
const clippings = debug
385-
? {}
386-
: {
387-
clipX: 0,
388-
clipY: 0,
389-
clipWidth: [90, -90].includes(chartRotation) ? chartDimensions.height : chartDimensions.width,
390-
clipHeight: [90, -90].includes(chartRotation) ? chartDimensions.width : chartDimensions.height,
391-
};
392383

393384
let brushProps = {};
394385
const isBrushEnabled = this.props.chartStore!.isBrushEnabled();
@@ -399,13 +390,6 @@ class Chart extends React.Component<ReactiveChartProps, ReactiveChartState> {
399390
};
400391
}
401392

402-
const layerClippings = {
403-
clipX: chartDimensions.left,
404-
clipY: chartDimensions.top,
405-
clipWidth: chartDimensions.width,
406-
clipHeight: chartDimensions.height,
407-
};
408-
409393
const className = classNames({
410394
'echChart--isBrushEnabled': this.props.chartStore!.isCrosshairCursorVisible.get(),
411395
});
@@ -443,15 +427,17 @@ class Chart extends React.Component<ReactiveChartProps, ReactiveChartState> {
443427
}}
444428
{...brushProps}
445429
>
446-
<Layer hitGraphEnabled={false} listening={false} {...layerClippings}>
430+
<Layer hitGraphEnabled={false} listening={false}>
447431
{this.renderGrids()}
448432
</Layer>
433+
<Layer hitGraphEnabled={false} listening={false}>
434+
{this.renderAxes()}
435+
</Layer>
449436

450437
<Layer
451438
x={chartDimensions.left + chartTransform.x}
452439
y={chartDimensions.top + chartTransform.y}
453440
rotation={chartRotation}
454-
{...clippings}
455441
hitGraphEnabled={false}
456442
listening={false}
457443
>
@@ -468,10 +454,6 @@ class Chart extends React.Component<ReactiveChartProps, ReactiveChartState> {
468454
)}
469455

470456
<Layer hitGraphEnabled={false} listening={false}>
471-
{this.renderAxes()}
472-
</Layer>
473-
474-
<Layer hitGraphEnabled={false} listening={false} {...layerClippings}>
475457
{this.renderBarValues()}
476458
</Layer>
477459
</Stage>

0 commit comments

Comments
 (0)