Add ms_tls13kdf buildtag for FIPS builds#8092
Conversation
|
Pinging @elastic/elastic-agent-control-plane (Team:Elastic-Agent-Control-Plane) |
|
Shouldn't the tag |
ycombinator
left a comment
There was a problem hiding this comment.
Should we also check for ms_tls13kdf around here?
💔 Build Failed
Failed CI Steps
History
|
|
Add ms_tls13kdf buildtag for FIPS builds (cherry picked from commit c2ecbaf)
|
This new tag has no effect on the generation of the FIPS notice file because there are no packages whose inclusion are conditional on the use of this tag? Correct? elastic-agent/dev-tools/mage/target/common/notice.go Lines 38 to 39 in 804f1ee We are only filtering on requirefips, just double checking adding another tag to the FIPS build doesn't affect the FIPS notice file. |





What does this PR do?
Add the
ms_tls13kdfbuild tag to FIPS builds.Why is it important?
microsoft/go TLSv1.3 kdf support (microsoft/go#1662) requires the
ms_tls13kdfbuild tag.