Remove guidance to lowercase http.request.method #840
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leehinman
force-pushed
the
remove_normalize_http_request_method
branch
from
8739e48 to
d3929f0
Compare
webmat
suggested changes
May 7, 2020
Contributor
webmat
left a comment
webmat
left a comment
There was a problem hiding this comment.
Let's put back some text to clarify what's happening on that field. I have a rough suggestion below.
webmat
reviewed
May 7, 2020
Contributor
webmat
left a comment
webmat
left a comment
There was a problem hiding this comment.
Thanks for the adjustment.
Now let's run make and commit the changes to update all artifacts.
I'm also waiting on the docs preview, to see how this will render in asciidoc. We may have to adjust this a bit. If you want to check it out locally, you can simply run make docs.
webmat
reviewed
May 7, 2020
webmat
reviewed
May 7, 2020
webmat
reviewed
May 7, 2020
CHANGELOG.next.md
Outdated
|
|
||
| #### Deprecated | ||
|
|
||
| * Remove guidance to lowercase `http.request.method` #840 |
Contributor
There was a problem hiding this comment.
Suggested change
| * Remove guidance to lowercase `http.request.method` #840 | |
| * Deprecate guidance to lowercase `http.request.method` #840 |
Sorry last lil change 😬
Contributor
|
And the doc preview is back: http://ecs_840.docs-preview.app.elstc.co/guide/en/ecs/master/ecs-http.html |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove guidance to lowercase http.request.method
Closes #838