-
Notifications
You must be signed in to change notification settings - Fork 448
Beef up the description of the log field set.
#540
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
MikePaquette
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested some wording tweaks, then LGTM.
9c52fa4 to
c9ef727
Compare
|
Ok, just updated this PR with Mike's comments. I think this clarification about the Let's review whether this new proposed definition fits well with the fields under What works well with the new definition
What does not work as well with the new definition
I'll merge this tomorrow, unless @ruflin & @MikePaquette chime back in with additional comments / suggestions. |
MikePaquette
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This is meant to help clarify the difference between
logandevent.Relates to #525 and address some concerns voiced in #516.