Add additional log.syslog fields #1793
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add additional fields for RFC 5424 messages (log.syslog.version, log.syslog.msgid, log.syslog.data) - Add log.syslog.hostname, log.syslog.appname, and log.syslog.procid for hostname, process name, and process ID fields present in syslog messages, respectively. These fields are added since it is not always known that user wants these values copied to the more general ECS fields (host.hostname, process.name, process.pid).
5 tasks
andrewkroh
reviewed
Feb 23, 2022
ebeahan
reviewed
Feb 24, 2022
ebeahan
approved these changes
Feb 28, 2022
Member
ebeahan
left a comment
ebeahan
left a comment
There was a problem hiding this comment.
LGTM! Thanks for making the adjustments.
Should these changes go into 8.2?
Contributor
Author
If we could do that, that would be great! The associated syslog parser/processor is also targeting 8.2. |
updating changelog entry to 8.2
kgeller
added a commit
to kgeller/ecs
that referenced
this pull request
Mar 1, 2022
- Add additional fields for RFC 5424 messages (log.syslog.version, log.syslog.msgid, log.syslog.data) - Add log.syslog.hostname, log.syslog.appname, and log.syslog.procid for hostname, process name, and process ID fields present in syslog messages, respectively. These fields are added since it is not always known that user wants these values copied to the more general ECS fields (host.hostname, process.name, process.pid). - Updating changelog entry to 8.2 Co-authored-by: Kylie Geller <[email protected]> # Conflicts: # experimental/generated/csv/fields.csv # generated/csv/fields.csv
kgeller
added a commit
that referenced
this pull request
Mar 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
log.syslog.msgid, log.syslog.data)
for hostname, process name, and process ID fields present in syslog
messages, respectively. These fields are added since it is not always
known that user wants these values copied to the more general ECS fields
(host.hostname, process.name, process.pid).