From 29995c5eabb7a008687e9ee392ac59d75cac2bba Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Manuel=20de=20la=20Pe=C3=B1a?= Date: Thu, 6 May 2021 14:07:58 +0200 Subject: [PATCH] chore: rename downloaded file (#1149) (cherry picked from commit fd419f40a10359b8f5c77763a8c3c01098d93e53) --- internal/utils/utils.go | 15 +++++++++++++-- 1 file changed, 13 insertions(+), 2 deletions(-) diff --git a/internal/utils/utils.go b/internal/utils/utils.go index c7a81d1bb0..3059381535 100644 --- a/internal/utils/utils.go +++ b/internal/utils/utils.go @@ -118,9 +118,20 @@ func FetchBeatsBinary(artifactName string, artifact string, version string, fall return filePath, err } - binariesCache[URL] = filePath + // use artifact name as file name to avoid having URL params in the name + sanitizedFilePath := path.Join(path.Dir(filePath), artifactName) + err = os.Rename(filePath, sanitizedFilePath) + if err != nil { + log.WithFields(log.Fields{ + "fileName": filePath, + "sanitizedFileName": sanitizedFilePath, + }).Warn("Could not sanitize downloaded file name. Keeping old name") + sanitizedFilePath = filePath + } + + binariesCache[URL] = sanitizedFilePath - return filePath, nil + return sanitizedFilePath, nil } var downloadURL string