Skip to content

Conversation

@nik9000
Copy link
Member

@nik9000 nik9000 commented Feb 25, 2019

Our compat-preprocessor wasn't properly handling "skipped" lines
sometimes, mostly because we didn't have any tests for them. This fixes
both problems. It is a prerequisite to switching the "Getting Started"
book to asciidoctor.

Our compat-preprocessor wasn't properly handling "skipped" lines
sometimes, mostly because we didn't have any tests for them. This fixes
both problems. It is a prerequisite to switching the "Getting Started"
book to asciidoctor.
@nik9000 nik9000 requested review from a user and ddillinger February 25, 2019 21:30
@nik9000
Copy link
Member Author

nik9000 commented Feb 25, 2019

@lcawl, I found this when looked into converting the next book in our list!

@nik9000 nik9000 mentioned this pull request Feb 25, 2019
@lcawl
Copy link
Contributor

lcawl commented Feb 26, 2019

Thanks, if I understand correctly, this is the cause of the following error when building the 6.7 Getting Started Guide via asciidoctor:

INFO:build_docs:/docs_build/resources/asciidoctor/lib/elastic_compat_preprocessor/extension.rb:129:in process_line': asciidoctor: FAILED: /doc/stack-docs/docs/en/getting-started/index.asciidoc: Failed to load AsciiDoc document - undefined method sub!' for nil:NilClass (NoMethodError)

@nik9000 nik9000 merged commit aaa55b9 into elastic:master Feb 26, 2019
@nik9000
Copy link
Member Author

nik9000 commented Feb 26, 2019

@lcawl, that is the one!

Thanks for reviewing @ddillinger!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants