Set BlockOwnerDeletion to false on PVCs #1891
Conversation
| // See https://github.com/elastic/cloud-on-k8s/issues/1884 | ||
| refs := claim.OwnerReferences | ||
| for i := range refs { | ||
| refs[i].BlockOwnerDeletion = &f |
There was a problem hiding this comment.
This is potentially changing other owner references as well? I would have expected you to only change the one we set here. I don't think it matters much, I was just wondering if you had a reason for it?
There was a problem hiding this comment.
I'm not sure in which cases we may have several owner references in the template, but my guess is that as long as there is at least one BlockOwnerDeletion set to true then the creation will fail.
So we must take care of all the owner references ?
| if err := controllerutil.SetControllerReference(&es, &claim, scheme); err != nil { | ||
| return nil, err | ||
| } | ||
| // Set block owner deletion to false as the statefulset controller might not be able to do that |
There was a problem hiding this comment.
to do that
Maybe needs half a sentence more. IIUC the statefulset controller cannot handle an owner reference with blockOwnerDeletion:true if it cannot set finalizers on the owning resource
3 participants
Fix #1884