Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal: kafka output #942

Merged
merged 3 commits into from
Feb 10, 2016
Merged

Proposal: kafka output #942

merged 3 commits into from
Feb 10, 2016

Conversation

urso
Copy link

@urso urso commented Feb 7, 2016

Kafka output basically wrapping github.com/Shopify/sarama library in libbeat + make it configurable.

Depends on: #927 and #940

@urso urso added enhancement in progress Pull request is currently in progress. discuss Issue needs further discussion. libbeat labels Feb 7, 2016
@urso urso force-pushed the feature/kafka-output branch 3 times, most recently from a905db4 to 1b938be Compare February 9, 2016 14:23
@urso urso added review and removed in progress Pull request is currently in progress. labels Feb 9, 2016
}
debugf("hosts: %v", hosts)

useType := kafkaDefaultTopicsFromType
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this configuration option is not documented.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh yes, forgot this one.

@tsg
Copy link
Contributor

tsg commented Feb 9, 2016

LGTM. I suggest some integration tests for a few of the common configuration (TLS/no-TLS, ACK/no-ACK), but those can come in a different PR.

@urso
Copy link
Author

urso commented Feb 10, 2016

History cleanup finished

tsg added a commit that referenced this pull request Feb 10, 2016
@tsg tsg merged commit 1a6c611 into elastic:master Feb 10, 2016
@urso urso deleted the feature/kafka-output branch February 11, 2016 10:33
@biswajit86
Copy link

Is there a need for implementing other PR's or can we start using kafka output in beats framework.

@anefassa
Copy link

This is great news on providing a Kafka output for beats. When is v5.0.0-GA targeted to be released?

In the meantime I have built from master to start testing it out. Any tips on how to configure the Kafka output?

@andrewkroh
Copy link
Member

@anefassa
Copy link

Thanks for sharing the docs. Kafka output with filebeat is working for me.

@mostolog
Copy link

Could anyone @elastic confirms if beat -> kafka is going to be available for version 5?

@ruflin
Copy link
Member

ruflin commented Jul 12, 2016

Yes, Kafka will be available in the 5.0 release. You can already tests it with the 5.0.0-alpha releases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discuss Issue needs further discussion. enhancement libbeat review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants