Publisher options cleanup #684
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| } | ||
|
|
||
| // TODO: add backoff | ||
| time.Sleep(1) |
There was a problem hiding this comment.
Do you plan to add this later? Ok for me but I suggest to open an issue then.
There was a problem hiding this comment.
No plans to add anything to redis module right now. The redis module has become orphaned and basically needs to be rewritten to use the outputs/modes module like elasticsearch and logstash outputs do.
|
LGTM. Don't forget CHANGELOG and I would suggest to squash the commits before merge. |
- have separate sync and guaranteed options:
- sync: just blocks until output plugin finished processing events
to be published
- guaranteed: is passed and handled in output plugin. If options is set,
sending is retried until success.
- guaranteed sending is handled by output plugin retrying infinitely until
events have been ACKed.
- Introduce publish Signal option
- Update publisher options in filebeat/winlogbeat
51 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to be published
sending is retried until success.
events have been ACKed.