Join the logging of the message and the newline into one Write #650
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewkroh
force-pushed
the
bugfix/logging-newline
branch
from
68d8157
to
18d0c0e
Compare
| @@ -66,15 +66,13 @@ func (rotator *FileRotator) WriteLine(line []byte) error { | |||
| return err | |||
| } | |||
| } | |||
|
|
|||
| line = append(line, "\n"...) | |||
There was a problem hiding this comment.
Using a rune literal would be better in this case. I will update. I made the change.
andrewkroh
force-pushed
the
bugfix/logging-newline
branch
from
18d0c0e
to
c3d0fa7
Compare
|
LGTM |
ruflin
added a commit
that referenced
this pull request
Jan 7, 2016
Join the logging of the message and the newline into one Write
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #646