Skip to content

[8.19](backport #46793) Bump Go version to 1.25.8#49328

Merged
ycombinator merged 2 commits into
8.19from
mergify/bp/8.19/pr-46793
Mar 6, 2026
Merged

[8.19](backport #46793) Bump Go version to 1.25.8#49328
ycombinator merged 2 commits into
8.19from
mergify/bp/8.19/pr-46793

Conversation

@mergify
Copy link
Copy Markdown
Contributor

@mergify mergify Bot commented Mar 6, 2026

This PR bumps up the Golang version to 1.25.8. It also:

  • removes the ms_tls13kdf Golang build tag when building in FIPS mode because this tag was only needed with Golang versions 1.24.x.
  • sets ths GODEBUG=tlsmlkem=0 environment variable when running FIPS140-only unit tests. This prevents errors like so: Failed to connect: crypto/ecdh: use of X25519 is not allowed in FIPS 140-only mode.
  • replaces any fmt.Sprintf("%s:%d", ip, port) code fragments with net.JoinHostPort(ip, strconv.Itoa(int(port))) to work with the new hostport go vet analyzer.
    This is an automatic backport of pull request Bump Go version to 1.25.8 #46793 done by Mergify.

* Bump Go version to 1.25.1

* Bump the version of golangci-lint

* Use net.JoinHostPort

* Remove references to the ms_tls13kdf build tag

* Download go module dependencies before GODEBUG=fips140=only is set

* Download go module dependencies before GODEBUG=fips140=only is set

* Download go module dependencies before GODEBUG=fips140=only is set

* Exclude X25519 curve types when testing in FIPS-140-only mode

* Only modify curve preferences

* Fix up fips140=only integration tests

* Forgot import

* Forgot import

* Fix TestConnectionTLS

* Set GODEBUG=tlsmlkem=0 for tests

* Remove unnecessary changes

* Remove pre-download of Go modules

* Running mage fmt

* Adding CHANGELOG

* Fixing IPv6 address

* Adding missed import

* Go version: s/1.25.2/1.25.4/g

* Rebasing, fixing conflicts, and bumping to Go version 1.25.8

* Bump npcap version

(cherry picked from commit c1cb121)

# Conflicts:
#	go.sum
#	libbeat/docs/version.asciidoc
@mergify mergify Bot added backport conflicts There is a conflict in the backported pull request labels Mar 6, 2026
@mergify mergify Bot requested review from a team as code owners March 6, 2026 19:18
@mergify
Copy link
Copy Markdown
Contributor Author

mergify Bot commented Mar 6, 2026

Cherry-pick of c1cb121 has failed:

On branch mergify/bp/8.19/pr-46793
Your branch is up to date with 'origin/8.19'.

You are currently cherry-picking commit c1cb121b7.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   .github/workflows/golangci-lint.yml
	modified:   .go-version
	modified:   NOTICE.txt
	modified:   auditbeat/Dockerfile
	new file:   changelog/fragments/1760385532-bump-golang-1.25.8.yaml
	modified:   dev-tools/kubernetes/filebeat/Dockerfile.debug
	modified:   dev-tools/kubernetes/heartbeat/Dockerfile.debug
	modified:   dev-tools/kubernetes/metricbeat/Dockerfile.debug
	modified:   dev-tools/mage/fips-settings.yaml
	modified:   dev-tools/mage/gotest.go
	modified:   dev-tools/packaging/package_test.go
	modified:   filebeat/magefile.go
	modified:   go.mod
	modified:   heartbeat/Dockerfile
	modified:   heartbeat/hbtest/hbtestutil.go
	modified:   heartbeat/monitors/active/http/http_test.go
	modified:   libbeat/processors/add_kubernetes_metadata/indexers.go
	modified:   libbeat/processors/add_kubernetes_metadata/indexers_test.go
	modified:   metricbeat/Dockerfile
	modified:   metricbeat/helper/server/tcp/tcp_test.go
	modified:   metricbeat/helper/server/udp/udp_test.go
	modified:   metricbeat/magefile.go
	modified:   metricbeat/module/apache/status/status_test.go
	modified:   metricbeat/module/http/_meta/Dockerfile
	modified:   metricbeat/module/vsphere/_meta/Dockerfile
	modified:   packetbeat/Dockerfile
	modified:   testing/go-ech/ech.go
	modified:   x-pack/metricbeat/magefile.go
	modified:   x-pack/metricbeat/module/airflow/statsd/data_test.go
	modified:   x-pack/metricbeat/module/stan/_meta/Dockerfile
	modified:   x-pack/packetbeat/scripts/mage/pcap.go
	modified:   x-pack/packetbeat/tests/system/app_test.go

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   go.sum
	both modified:   libbeat/docs/version.asciidoc

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@mergify mergify Bot requested review from andrzej-stencel and rdner and removed request for a team March 6, 2026 19:18
@botelastic botelastic Bot added the needs_team Indicates that the issue/PR needs a Team:* label label Mar 6, 2026
@mergify mergify Bot requested review from michel-laterman and swiatekm and removed request for a team March 6, 2026 19:18
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Mar 6, 2026

🤖 GitHub comments

Just comment with:

  • run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)

@github-actions github-actions Bot added the Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team label Mar 6, 2026
@elasticmachine
Copy link
Copy Markdown
Contributor

Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane)

@botelastic botelastic Bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Mar 6, 2026
@mergify mergify Bot mentioned this pull request Mar 6, 2026
@ycombinator ycombinator enabled auto-merge (squash) March 6, 2026 21:38
@ycombinator ycombinator merged commit b4beb4c into 8.19 Mar 6, 2026
212 of 215 checks passed
@ycombinator ycombinator deleted the mergify/bp/8.19/pr-46793 branch March 6, 2026 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport conflicts There is a conflict in the backported pull request Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants