Fix issue that new prospector was not reloaded on conflict #4128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ruflin
added
bug
Filebeat
|
See #4133 |
ruflin
added
review
and removed
in progress
ruflin
changed the title
ruflin
force-pushed
the
reload-fix
branch
2 times, most recently
from
350a03b
to
6605b7f
Compare
|
jenkins, retest it |
|
WFG. |
A new prospector cannot be started if one of the states he starts with is not set to Finished. In this case the prospector should wait until the old prospector is shutdown and try again on the next reload. This did not work as intended so far because if loading failed, the running prospector was stopped and the non running was not started again on the next run. This change should fix it. See also https://discuss.elastic.co/t/error-when-reloading-prospectors-for-filebeat/83082/5 Closes elastic#4133
ruflin
added
needs_backport
ruflin
added a commit
to ruflin/beats
that referenced
this pull request
May 5, 2017
) A new prospector cannot be started if one of the states he starts with is not set to Finished. In this case the prospector should wait until the old prospector is shutdown and try again on the next reload. This did not work as intended so far because if loading failed, the running prospector was stopped and the non running was not started again on the next run. This change should fix it. See also https://discuss.elastic.co/t/error-when-reloading-prospectors-for-filebeat/83082/5 Closes elastic#4133 (cherry picked from commit d98e54e)
ruflin
removed
the
needs_backport
tsg
pushed a commit
that referenced
this pull request
May 10, 2017
…4227) A new prospector cannot be started if one of the states he starts with is not set to Finished. In this case the prospector should wait until the old prospector is shutdown and try again on the next reload. This did not work as intended so far because if loading failed, the running prospector was stopped and the non running was not started again on the next run. This change should fix it. See also https://discuss.elastic.co/t/error-when-reloading-prospectors-for-filebeat/83082/5 Closes #4133 (cherry picked from commit d98e54e)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A new prospector cannot be started if one of the states he starts with is not set to Finished. In this case the prospector should wait until the old prospector is shutdown and try again on the next reload. This did not work as intended so far because if loading failed, the running prospector was stopped and the non running was not started again on the next run. This change should fix it.
See also https://discuss.elastic.co/t/error-when-reloading-prospectors-for-filebeat/83082/5
Closes #4133