Support Alibaba Cloud provider for add_cloud_metadata proccessor #4111
Conversation
|
Jenkins standing by to test this. If you aren't a maintainer, you can ignore this comment. Someone with commit access, please review this and clear it for Jenkins to run. |
1 similar comment
|
Jenkins standing by to test this. If you aren't a maintainer, you can ignore this comment. Someone with commit access, please review this and clear it for Jenkins to run. |
| // Alibaba Cloud Metadata Service | ||
| // Document https://help.aliyun.com/knowledge_detail/49122.html | ||
| func newAlibabaCloudMetadataFetcher(c common.Config) (*metadataFetcher, error) { | ||
| ecsMetadataHost := "100.100.100.200" |
There was a problem hiding this comment.
It's interesting that this is a fixed IP and not a domain name. Couldn't make much sense of the docs above unfortunately ;-)
There was a problem hiding this comment.
Yep, maybe metadata is not a really important feature for Chinese users, the design looks not so serious in both Tencent Cloud and Alibaba Cloud :-)
Couldn't make much sense of the docs above unfortunately ;-)
You mean remove the document comment?
| @@ -359,6 +360,22 @@ _Tencent Cloud_ | |||
| } | |||
| ------------------------------------------------------------------------------- | |||
|
|
|||
| _Alibaba Cloud_ | |||
|
|
|||
There was a problem hiding this comment.
I realize that this is supposed to just be examples of the output, but it would be good to mention something like, "Only when VPC is selected as the network type of the instance, you can get the metadata."
@dedemorton Maybe you have wording or formatting suggestions.
There was a problem hiding this comment.
Let's change the wording because we don't want to take the text verbatim from the Alibaba docs. How about adding this before the example:
This metadata is only available when VPC is selected as the network type of the instance.
Or, assuming we are talking about an ECS instance here (apologies for my ignorance), this would be even better and less confusing for users:
This metadata is only available when VPC is selected as the network type of the ECS instance.
There was a problem hiding this comment.
Added on the position above the example output.
| @@ -3,6 +3,7 @@ package add_cloud_metadata | |||
| import "github.com/elastic/beats/libbeat/common" | |||
|
|
|||
| // Tenccent Cloud Metadata Service | |||
|
jenkins, test it |
|
jenkins, test it |
|
Did my changes affect symlink rotate feature? |
|
@athom no, change is not related to the CI failure. |
Follow PR of #4023
Aims to support Alibaba Cloud provider for add_cloud_metadata processor.
Similar with Tencent Cloud, Alibaba's metadata services requires multiple requests too.
Here is the official document.
Tested on an esc instance with os ubuntu 16.04.
Note, Alibaba cloud's metadata services works only when the instance's network type is VPC.