Change error to error.message #3987
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ruflin
force-pushed
the
error-message
branch
2 times, most recently
from
e005c47
to
dfb3c57
Compare
Currently error message in metricbeat are written into the `error` field. In heartbeat `error.message` is used. To unify the error structure and allow in the future to support things like `error.code` and others inside the error, `error` is changed to `error.message`. Currently internally all `error` are just written to `error.message`. In future PR's an internal logic should be added to support `error.code` and others so Metricsets, Prospectors etc. can make use of it. Changes * Change `error` to `error.message` * Move error mappings from heartbeat to libbeat Closes elastic#3951
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently error message in metricbeat are written into the
errorfield. In heartbeaterror.messageis used. To unify the error structure and allow in the future to support things likeerror.codeand others inside the error,erroris changed toerror.message.Currently internally all
errorare just written toerror.message. In future PR's an internal logic should be added to supporterror.codeand others so Metricsets, Prospectors etc. can make use of it.Changes
errortoerror.messageCloses #3951