Add elasticsearch module with stats metricset #3903
Conversation
| "successful": 11, | ||
| "total": 22 | ||
| }, | ||
| "store": { |
There was a problem hiding this comment.
Is this store.size.bytes the total disk space used by indices? If so, that's awesome, if not then I'm not sure we want it.
There was a problem hiding this comment.
I will add it in a follow up PR.
There was a problem hiding this comment.
@joegallo The es docs state: The size of the index. So I think it is what we assumed above.
| "failed": 0, | ||
| "successful": 11, | ||
| "total": 22 | ||
| }, |
There was a problem hiding this comment.
I think docs, segments, shards all look fine. I'd like to have an indices section here as well, though, with a total count (or maybe closed and total)? Whatever you think makes sense on that.
There was a problem hiding this comment.
will add it in a follow up PR.
ruflin
force-pushed
the
mb-elasticsearch-module
branch
from
9623128
to
2987987
Compare
|
|
||
| import "os" | ||
|
|
||
| func GetEnvHost() string { |
There was a problem hiding this comment.
[golint] reported by reviewdog 🐶
exported function GetEnvHost should have comment or be unexported
| return host | ||
| } | ||
|
|
||
| func GetEnvPort() string { |
There was a problem hiding this comment.
[golint] reported by reviewdog 🐶
exported function GetEnvPort should have comment or be unexported
| return port | ||
| } | ||
|
|
||
| func GetConfig(metricset string) map[string]interface{} { |
There was a problem hiding this comment.
[golint] reported by reviewdog 🐶
exported function GetConfig should have comment or be unexported
This adds the stats metricset for the elasticsearch module. The stats metricset gives and overview over the current state of the cluster.
ruflin
force-pushed
the
mb-elasticsearch-module
branch
from
2987987
to
a6cc12f
Compare
|
jenkins, retest it |
| @@ -0,0 +1,4 @@ | |||
| == elasticsearch Module | |||
|
|
|||
| This is the elasticsearch Module. The elasticsearch module contains a minimal set of metrics to enable monitoring of elasticsearch across multiple versions. | |||
There was a problem hiding this comment.
Should we link to xpack monitoring here, as a more complete alternative? Can come in a different PR.
There was a problem hiding this comment.
+1. Will also add it in Kibana.
|
Changelog? |
This adds the stats metricset for the elasticsearch module. The stats metricset gives and overview over the current state of the cluster.