Skip to content

migrate libbeat pipeline #37725

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 62 commits into from
Feb 7, 2024
Merged

migrate libbeat pipeline #37725

merged 62 commits into from
Feb 7, 2024

Conversation

@sharbuz
Copy link
Contributor

@sharbuz sharbuz commented Jan 24, 2024 •
edited
Loading

What is the problem this PR solves?

Jenkins->Buildkite pipelines migration

How does this PR solve the problem?

  1. Migrate the libbeat pipeline
    https://buildkite.com/elastic/beats-libbeat/builds?branch=sharbuz%3Amigrate-libbeat-pipeline
  2. Update the common conditions/rules for starting the pipelines (excluded the part from the main pipeline)

Examples of the builds:
Metricbeat: https://buildkite.com/elastic/beats-metricbeat/builds/1992
Libbeat: https://buildkite.com/elastic/beats-libbeat/builds/700

Related issues

https://github.com/elastic/ingest-dev/issues/1693

@sharbuz sharbuz added enhancement Team:Elastic-Agent Label for the Agent team backport-7.17 Automated backport to the 7.17 branch with mergify backport-v8.12.0 Automated backport with mergify labels Jan 24, 2024
@sharbuz sharbuz requested review from jlind23, mrodm and v1v January 24, 2024 15:28
@sharbuz sharbuz self-assigned this Jan 24, 2024
@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Jan 24, 2024
v1v
v1v reviewed Jan 24, 2024
View reviewed changes
@sharbuz sharbuz removed request for jlind23 and mrodm January 24, 2024 19:31
v1v
v1v reviewed Jan 25, 2024
View reviewed changes
Siarhei Harbuz added 3 commits January 25, 2024 16:26
@sharbuz sharbuz removed the Team:Elastic-Agent Label for the Agent team label Jan 25, 2024
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Jan 25, 2024
@botelastic
Copy link

botelastic bot commented Jan 25, 2024

This pull request doesn't have a Team:<team> label.

@sharbuz @v1v
Update catalog-info.yaml
6ee43ff 
Co-authored-by: Victor Martinez <[email protected]>
@sharbuz sharbuz enabled auto-merge (squash) February 6, 2024 10:32
@sharbuz
Copy link
Contributor Author

sharbuz commented Feb 6, 2024 •
edited
Loading

The pipeline will finish with errors because of:
#37873
#37870
@v1v suggested using different PRs for that.
All other remarks have been fixed.
CC @dliappis

@sharbuz sharbuz disabled auto-merge February 6, 2024 10:53
@sharbuz sharbuz mentioned this pull request Feb 6, 2024
Merged
@sharbuz sharbuz enabled auto-merge (squash) February 6, 2024 12:19
@mergify
Copy link
Contributor

mergify bot commented Feb 6, 2024

This pull request is now in conflicts. Could you fix it? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b migrate-libbeat-pipeline upstream/migrate-libbeat-pipeline
git merge upstream/main
git push upstream migrate-libbeat-pipeline

@sharbuz sharbuz requested review from a team and jlind23 February 6, 2024 16:24
@sharbuz
Copy link
Contributor Author

sharbuz commented Feb 7, 2024

/test

@elasticmachine
Copy link
Collaborator

elasticmachine commented Feb 7, 2024

💔 Build Failed

Failed CI Steps

History

cc @sharbuz

@sharbuz
Copy link
Contributor Author

sharbuz commented Feb 7, 2024

/test

1 similar comment
@sharbuz
Copy link
Contributor Author

sharbuz commented Feb 7, 2024

/test

@jlind23 jlind23 disabled auto-merge February 7, 2024 11:25
@jlind23 jlind23 merged commit 625ba40 into elastic:main Feb 7, 2024
@jlind23
Copy link
Collaborator

jlind23 commented Feb 7, 2024

Force merging this as the failure is unrelated. @sharbuz will create a follow up issue for @axw and @bturquet to investigate.

mergify bot pushed a commit that referenced this pull request Feb 7, 2024
@sharbuz @mergify
migrate libbeat pipeline (#37725)
cc20d1f 
(cherry picked from commit 625ba40)
mergify bot pushed a commit that referenced this pull request Feb 7, 2024
@sharbuz @mergify
migrate libbeat pipeline (#37725)
83db121 
(cherry picked from commit 625ba40)

# Conflicts:
#	catalog-info.yaml
This was referenced Feb 7, 2024
Merged
Merged
sharbuz added a commit that referenced this pull request Feb 7, 2024
@mergify @sharbuz
migrate libbeat pipeline (#37725) (#37900)
1bc6e9b 
(cherry picked from commit 625ba40)

Co-authored-by: sharbuz <[email protected]>
sharbuz added a commit that referenced this pull request Feb 7, 2024
@mergify @sharbuz
[7.17](backport #37725) migrate libbeat pipeline (#37899)
0f121fd 
* migrate libbeat pipeline (#37725)

(cherry picked from commit 625ba40)

# Conflicts:
#	catalog-info.yaml

* Update catalog-info.yaml

* Update catalog-info.yaml

---------

Co-authored-by: sharbuz <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dliappis dliappis dliappis approved these changes

@v1v v1v v1v approved these changes

@faec faec Awaiting requested review from faec faec was automatically assigned from elastic/elastic-agent-data-plane

@leehinman leehinman Awaiting requested review from leehinman leehinman was automatically assigned from elastic/elastic-agent-data-plane

@jlind23 jlind23 Awaiting requested review from jlind23

Assignees

@sharbuz sharbuz

Labels

arm Enable builds in the CI for ARM testing backport-7.17 Automated backport to the 7.17 branch with mergify backport-v8.12.0 Automated backport with mergify enhancement libbeat Metricbeat Metricbeat needs_team Indicates that the issue/PR needs a Team:* label

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@sharbuz @elasticmachine @jlind23 @dliappis @v1v