Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry-pick #23424 to 7.x: Sync fixes from Integration Package Testing #24077

Merged
merged 2 commits into from
Feb 17, 2021

Conversation

andrewkroh
Copy link
Member

@andrewkroh andrewkroh commented Feb 16, 2021

Cherry-pick of PR #23424 to 7.x branch. Original message:

What does this PR do?

In elastic/integrations#377 we added tests for packages that were ported over from Filebeat modules. Those tests unconvered a few minor issues that were fixed in package. This brings those fixes back into Filebeat modules.

Why is it important?

Checklist

  • My code follows the style guidelines of this project
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Related issues

@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Feb 16, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Feb 16, 2021
@andrewkroh andrewkroh force-pushed the backport_23424_7.x branch 2 times, most recently from 9394635 to 78de307 Compare February 16, 2021 22:18
* Sync changes to AWS CloudTrail

elastic/integrations#408

* Sync changes to CheckPoint Firewall

Change type of event.severity.

elastic/integrations#409

* Sync changes from Cisco ASA / FTD

elastic/integrations#414

* Sync changes from Cisco IOS

Make icmp and igmp fields strings because they are keywords.

elastic/integrations#416

* Sync changes to CrowdStrike Falcon

Fix some field types.

elastic/integrations#377

* Sync changes to Fortinet Firewall

Drop assignip if the value is "N/A".

elastic/integrations#437

* Sync changes to Juniper SRX

Convert event.risk values to float
Protect against missing event.timezone
Convert event.severity to long.

elastic/integrations#443

* Sync changes to Suricata EVE

Convert suricata.eve.flow_id to string because the field is a keyword in the mapping.

elastic/integrations#457

* Sync changes to Zeek DNS

Fix usages of ignore_failure with convert processor.
Make DNS transaction ID a string.

elastic/integrations#448

* Add changelog

(cherry picked from commit bf46572)
@elasticmachine
Copy link
Collaborator

elasticmachine commented Feb 16, 2021

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: Pull request #24077 updated

  • Start Time: 2021-02-16T23:32:49.955+0000

  • Duration: 50 min 27 sec

  • Commit: 75886d7

Test stats 🧪

Test Results
Failed 0
Passed 6810
Skipped 1057
Total 7867

Trends 🧪

Image of Build Times

Image of Tests

💚 Flaky test report

Tests succeeded.

Expand to view the summary

Test stats 🧪

Test Results
Failed 0
Passed 6810
Skipped 1057
Total 7867

@adriansr adriansr merged commit 94b6732 into elastic:7.x Feb 17, 2021
@zube zube bot removed the [zube]: Done label May 18, 2021
@andrewkroh andrewkroh deleted the backport_23424_7.x branch January 14, 2022 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants