Skip to content

Conversation

@kvch
Copy link
Contributor

@kvch kvch commented Oct 13, 2020

Cherry-pick of PR #21736 to 7.x branch. Original message:

What does this PR do?

This PR adds the missing configuration annotations to the scanner config.

Why is it important?

Now the following configuration can be accepted:

prospector.scanner.check_interval: 10s
prospector.scanner.exclude_files: ["something"]

Checklist

  • My code follows the style guidelines of this project
    - [ ] I have commented my code, particularly in hard-to-understand areas
    - [ ] I have made corresponding changes to the documentation
    - [ ] I have made corresponding change to the default configuration files
    - [ ] I have added tests that prove my fix is effective or that my feature works
    - [ ] I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

@kvch kvch added [zube]: In Review backport Team:Services (Deprecated) Label for the former Integrations-Services team labels Oct 13, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/integrations-services (Team:Services)

@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Oct 13, 2020
@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: [Pull request #21769 opened]

  • Start Time: 2020-10-13T18:49:04.326+0000

  • Duration: 70 min 29 sec

Test stats 🧪

Test Results
Failed 0
Passed 4447
Skipped 564
Total 5011

Copy link
Contributor

@michalpristas michalpristas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

backport looks 🆗

@kvch kvch merged commit 3d530cc into elastic:7.x Oct 15, 2020
@zube zube bot removed the [zube]: Done label Jan 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Team:Services (Deprecated) Label for the former Integrations-Services team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants