Add client address to events from http server module #18336
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
1 similar comment
Contributor
|
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
botelastic
bot
added
the
needs_team
vjsamuel
force-pushed
the
add_client_address
branch
from
b2e5d31 to
34b8252
Compare
Contributor
💔 Build Failed
Expand to view the summary
Build stats
Steps errorsExpand to view the steps failures
Log outputExpand to view the last 100 lines of log output
|
exekias
approved these changes
May 7, 2020
Contributor
|
ok to test |
Contributor
|
Pinging @elastic/integrations (Team:Integrations) |
ChrsMark
added
needs_backport
Contributor
|
jenkins test this please |
6 tasks
exekias
added
v7.9.0
and removed
needs_backport
exekias
pushed a commit
to exekias/beats
that referenced
this pull request
May 8, 2020
(cherry picked from commit da1ba72)
exekias
pushed a commit
that referenced
this pull request
May 19, 2020
(cherry picked from commit da1ba72) Co-authored-by: Vijay Samuel <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds client address as
service.addressas part of events coming in from http server moduleWhy is it important?
It seems to be a gap in the module while things were moved to ECS
Checklist
CHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.