packetbeat: nfs: fix first-class operation code in compound #1821
Conversation
|
Jenkins standing by to test this. If you aren't a maintainer, you can ignore this comment. Someone with commit access, please review this and clear it for Jenkins to run; then say 'jenkins, test it'. |
1 similar comment
|
Jenkins standing by to test this. If you aren't a maintainer, you can ignore this comment. Someone with commit access, please review this and clear it for Jenkins to run; then say 'jenkins, test it'. |
|
jenkins, test it |
| @@ -167,18 +167,20 @@ func (nfs *Nfs) eatData(op int, xdr *Xdr) { | |||
|
|
|||
| func (nfs *Nfs) getV4Opcode(xdr *Xdr) string { | |||
|
|
|||
| // did we found a main operation opcode? | |||
|
makes sense, updated. |
|
@ruflin are there more changes required? |
| // | ||
| // GETATTR is the main operation. | ||
| // | ||
| // This function tries to guess main purpose of the request. If not found, then the last operation is used. |
There was a problem hiding this comment.
Very nice explanation. Thanks!!!
some minor details:
- I don't see the caller of getV4Opcode being changed. Does it compile?
- spacing on line 170 and 172 seems to be a little off
- godoc convention kinda mandates putting the function and short description first (before going into detail):
findV4MainOpcode finds the main operation in a compound call. If no main operation can be found, the last operation in compound call is returned.
Compount requests group ...
You can remove the last line This function tries..., as this information should be present at beginning of comment (see my sample).
There was a problem hiding this comment.
Question: Is there a chance of having multiple 'main' operations in one compound request?
There was a problem hiding this comment.
findV4MainOpcode is called in nfs.go:29, it compiles :)
There was a problem hiding this comment.
Technically, one can build a compound with READDIR and WRITE in it. In practice, nfs clients don't do that, as all nfs requests triggered by user activities, and there are no posix call that will trigger readdir+write. Well, synthetic clients can....but they used only for server functional testing.
NFS4 compound operations can be constructed from multiple single requests. Nevertheless, each compound request as a main operation. current code failing to detect main operation if it was in the middle of compound call. Signed-off-by: Tigran Mkrtchyan <[email protected]>
|
Thanks for the fix and all the patience! |
NFS4 compound operations can be constructed from multiple
single requests. Nevertheless, each compound request as a
main operation.
current code failing to detect main operation if it was in
the middle of compound call.
Signed-off-by: Tigran Mkrtchyan [email protected]