Move "beat" (ex-"shipper") config settings to be top level #1570
Conversation
| # The tags of the shipper are included in their own field with each | ||
| # transaction published. Tags make it easy to group servers by different | ||
| # logical properties. | ||
| #tags: ["service-X", "web-tier"] |
There was a problem hiding this comment.
@urso @andrewkroh I remember we discussed once if we should perhaps move these unter a "meta" namespace. Now that we break BC anyways? But not 100% convinced we should do it.
There was a problem hiding this comment.
I think we introduced them in 5.0-alpha1, so it wouldn't even be a real BWC change.
There was a problem hiding this comment.
In case we also use filebeat.prospector.0.meta.fields it would be. But it makes path even longer.
Side note: How nice is the above that I can write a config example in one line :-)
There was a problem hiding this comment.
I see, if we do it everywhere, yes. To me, it's not worth making these config paths longer, especially since we just add "meta", which is everyone's guess what it means :)
|
LGTM. See comments. |
tsg
force-pushed
the
config_move_beat_to_toplevel
branch
from
5aa78bb
to
8f74744
Compare
|
@ruflin i rebased on top of master. There's still a change in the topbeat template, but not mertricbeat. |
|
LGTM |
|
@tsg I suggest to remove geoip as part of a second PR because then we have a specific commit / pr we can reference to for the BC break. I restarted the appveyor build but the failing could be related to this change ... |
Part of elastic#1417. Done in a non-BWC way, because I think it's not worth complicating the code. I'd rather have a script that migrates the configuration.
tsg
force-pushed
the
config_move_beat_to_toplevel
branch
2 times, most recently
from
6aeb2b5
to
d1274a2
Compare
The list has grown quite long, switching to ucfg validation for this would be nice. Also added explicit key names to config.
tsg
force-pushed
the
config_move_beat_to_toplevel
branch
from
d1274a2
to
845cd14
Compare
|
This should be ready for merging. |
Part of #1417. Done in a non-BWC way, because I think it's not worth
complicating the code. I'd rather have a script that migrates the
configuration.