Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[vSphere] Graceful handling of logout from vSphere #43357

Open
ishleenk17 opened this issue Mar 19, 2025 · 1 comment · May be fixed by #43449
Open

[vSphere] Graceful handling of logout from vSphere #43357

ishleenk17 opened this issue Mar 19, 2025 · 1 comment · May be fixed by #43449
Assignees
@stefans-elastic
Labels
needs_team Indicates that the issue/PR needs a Team:* label

Comments

@ishleenk17
Copy link
Contributor

We need to add retry logic and graceful error handling in the logout logic of vSphere.

In vsphere, host.go and other metricsets, where we are logging out like below

defer func() {
	if err := client.Logout(ctx); err != nil {
		m.Logger().Errorf("error trying to logout from vSphere: %v", err)
  1. Add retry logic (maybe 3 times)
  2. Graceful handling using Warnf in case it fails after 3 retries.
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Mar 19, 2025
@botelastic
Copy link

botelastic bot commented Mar 19, 2025

This issue doesn't have a Team:<team> label.

@stefans-elastic stefans-elastic linked a pull request Mar 24, 2025 that will close this issue
Open
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@stefans-elastic stefans-elastic

Labels
needs_team Indicates that the issue/PR needs a Team:* label
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add retry logic for vSphere client Logout operation stefans-elastic/beats
2 participants
@ishleenk17 @stefans-elastic