-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Metricbeat downcases host.name #38689
Comments
This issue doesn't have a |
This discussion has been going on for years now.
APM should also normalize and lowercase Original host name should be in |
@roshan-elastic I think so. If we're normalizing data we need to do it for all methods of ingest. |
By APM agent spec (https://github.com/elastic/apm/blob/main/specs/agents/metadata.md#hostname) APM agents should be lowercasing the value they send to APM server ( This was added to our specs about 9mo ago in elastic/apm#805 THis issue elastic/apm#794 has links to the implementation issues for each of the APM agents. That issue is "closed" for all but the Go APM Agent. We'd have to do some digging to see what version of each APM agent got this change and possible confirm that they are indeed lowercasing. Do we have any info on which particular APM agents we are talking about here? Previous discussion(s): Other possible wrinkles:
|
Thanks for this @trentm - it sounds like our intent is to lower-case
@smith is this something you or someone in the team can share? I'm only really worried if it's something that isn't going to be addressed eventually. |
I asked on the originating issue: elastic/kibana#178650 (comment)
Development focus for the Go Agent is on the OTel side, so I'm not sure how timely any change would be here. Also I gather we'll have the same issue with OTel APM agents, where the |
That's OK - the main thing is that we're aligned on how to solve it (we can sort 'when' via prioritisation etc).
Great catch. @AlexanderWert / @mlunadia / @tommyers-elastic - Do you think we can enforce standardisation for OTel data? This issue is showing the pitfalls of mixing cases etc - it leads to dup data/confusing user experiences. Note : This issue is specifically focusing on lower-casing |
All of this is a result of this change in ECS (~a year ago): elastic/ecs#2122 So, now we have a mix of old collectors (that not necessarily do lowercasing) and newer collectors (that do lowercasing). In OpenTelemetry SemanticConventions I think, the actual problem is that we use --> I really hope that with Assets / Entities these kind of things will be resolved! |
Using host.id sounds good to me. For the current APM agents, it was only very recently added to APM agent specs. Only the Java APM agent will be producing |
That's a great point @AlexanderWert. I think that sounds sensible but I'm worried about what % of our customers will be able to supply this with current collection - especially as we want to leverage the host identifier across metricbeat, filebeat and the elastic agent integrations (and OTel). Looking at one of our own clusters ( It's a similar story on I believe this is likely representative of our customer base too...we might be able to get telemetry from the BI team if we need more data. Do you have any thoughts? @smith not sure if you have an opinion on this? |
@roshan-elastic we'll probably have to fall back to attempting to correlate things using |
Using host.id is absolutely not ideal. We have working correlations between datasets containing lowercase fqdn's from logs with datasets where only an ip is known. A reverse dns lookup enables us to correlate network data (which does not contain any hostnames) with host data. Please please let's not go back in time and choose a solution which doesn't make any sense. Lowercase fqdn in host.name is really tthe primary key you want to correlate on. NOT host.id, as a lot of datasets contain an id like '55de390e-6781-485a-a5c2-463180e52874'. How on earth do we have to correlate that with a lowercase fqdn in a dataset which has absolutely no idea where it whould get this host.id from?? |
@willemdh ➕ and thanks for the detail. |
@smith For your immediate problem: metricbeat sets agent.name with the same value as host.name without domain, but preserving case, if not instructed otherwise AFAIK. Is this also lowercased now? Would that pose as a useful alternative for you? Personally I agree with this, whenever someone tells me to check a host, I have to doublecheck if it spelled capital or not. The fields are of type "keyword" so that matters. Isn't this a problem that is isolated to windows? I am unaware of Unix-like systems that return mixed-case hostnames. @willemdh metricbeat (8.11.4) does not generate host.hostname on my system, nor agent.hostname. |
We first diagnosed it with MacOS. |
It appears metricbeat (and possibly other beats/agent integrations) converts the
host.name
to all lowercase. This causes problems when trying to associate with other names.We would expect the host.name to be unmodified as is the case with APM server.
The text was updated successfully, but these errors were encountered: