Strip bom from message #2351
Merged
Strip bom from message #2351
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ruflin
added
in progress
| @@ -20,6 +22,10 @@ func (p *StripNewline) Next() (Message, error) { | |||
|
|
|||
| L := message.Content | |||
| message.Content = L[:len(L)-lineEndingChars(L)] | |||
|
|
|||
| // Strip BOM | |||
| message.Content = bytes.Trim(message.Content, "\xef\xbb\xbf") | |||
There was a problem hiding this comment.
the BOM sequence can only be at start of file/stream. Should/Must not in between. What about utf-32 bom?
ruflin
added
review
and removed
discuss
Reading a file with a bom included the bom with the first event. This change removes the bom part from the first event in case it exists. * Tests for utf-8 and utf-16 added Closes elastic#1349
|
Nice! Easier than I would have thought. I let @urso have a look as well. |
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reading a file with a bom included the bom with the first event. This change removes the bom part from the first event in case it exists.
Closes #1349