Skip to content

Commit 9e28e06

Browse files
gmarsayGuillaume Marsayjustinkambic
authored andcommitted
[Heartbeat] Change size of data on ICMP packet (#29948)
* [Heartbeat] Change size of data on ICMP packet * Add CHANGELOG entry. Co-authored-by: Guillaume Marsay <[email protected]> Co-authored-by: Justin Kambic <[email protected]> (cherry picked from commit da9720c)
1 parent 599f0c3 commit 9e28e06

File tree

2 files changed

+2
-1
lines changed

2 files changed

+2
-1
lines changed

CHANGELOG.next.asciidoc

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,7 @@ https://github.com/elastic/beats/compare/v7.0.0-alpha2...master[Check the HEAD d
2222
- Fix broken macOS ICMP python e2e test. {pull}29900[29900]
2323
- Only add monitor.status to browser events when summary. {pull}29460[29460]
2424
- Also add summary to journeys for which the synthetics runner crashes. {pull}29606[29606]
25+
- Update size of ICMP packets to adhere to standard min size. {pull}29948[29948]
2526

2627
*Metricbeat*
2728

heartbeat/monitors/active/icmp/stdloop.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -346,7 +346,7 @@ func (l *stdICMPLoop) sendEchoRequest(addr *net.IPAddr) (*requestContext, error)
346346
l.requests[id] = ctx
347347
l.mutex.Unlock()
348348

349-
payloadBuf := make([]byte, 0, 8)
349+
payloadBuf := make([]byte, 48, 48)
350350
payload := bytes.NewBuffer(payloadBuf)
351351
ts := time.Now()
352352
binary.Write(payload, binary.BigEndian, ts.UnixNano())

0 commit comments

Comments
 (0)