fill in ECS-compat top-level fields from context #1766
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
graphaelli
commented
Jan 11, 2019
jalvz
approved these changes
Jan 11, 2019
Contributor
jalvz
left a comment
jalvz
left a comment
There was a problem hiding this comment.
rebasing master should fix the test
* agent <- context.service.agent * host <- context.system * process <- context.process * process.args <- context.process.argv, now indexed * service <- context.service Also indexes observer.listening, missed previously.
simitt
reviewed
Jan 11, 2019
Contributor
simitt
left a comment
simitt
left a comment
There was a problem hiding this comment.
Will moving context.requrest.url.* -> url.* and context.response.* -> http.response.* be handled in an extra PR?
I can take a look at the skipped test (rebasing onto master did not solve it).
Contributor
|
Hmm, i thought it was because of the onboarding document ordering |
Contributor
|
It is because the metadata are moved out of |
simitt
force-pushed
the
ecs-move-context
branch
from
15ccca2 to
8c8b231
Compare
Contributor
|
@graphaelli I did a |
originally moved from system.platform
Member
Author
|
Thanks for the fixups. All review feedback has been addressed and one test has been skipped, @simitt is already working on that one, thank you. |
simitt
approved these changes
Jan 11, 2019
Member
Author
|
only the sync job failed, as expected. |
This was referenced Jan 11, 2019
graphaelli
added a commit
to graphaelli/apm-integration-testing
that referenced
this pull request
Jan 11, 2019
graphaelli
added a commit
to graphaelli/apm-integration-testing
that referenced
this pull request
Jan 11, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also indexes observer.listening, missed previously.