Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Breaking changes for 8.0 #2631

Closed
1 of 16 tasks
graphaelli opened this issue Aug 23, 2019 · 6 comments
Closed
1 of 16 tasks

Breaking changes for 8.0 #2631

graphaelli opened this issue Aug 23, 2019 · 6 comments
Labels
Milestone

Comments

@graphaelli
Copy link
Member

graphaelli commented Aug 23, 2019

Consolidated list of breaking changes we should consider for the next major.


Discarded for 8.0:

- [ ] Remove null values from Json Spec (from #1410)
- [ ] Add labels and deprecate tags on Intake API (from #1835)
- [ ] Move onboarding index to system/dot-prefix or saved object
- [ ] Multiple listener support (from #1405)
- [ ] Synchronous upload of Sourcemaps or consider to move upload endpoint to Kibana (from #2862 )
- [ ] move pipeline configuration into index template / use final_pipeline (Moving to Fleet.)
- [ ] restructure apm-server.yml file to follow along with filebeat input structure as suggested (Jaeger/OTLP will be served on the same port as the Elastic APM agent protocol)


  • Cross out rather than deleting abandoned ideas
  • Check off implemented ideas
  • Reopen/reuse existing issues if proceeding with that idea
@jalvz
Copy link
Contributor

jalvz commented Sep 4, 2019

I won't create an issue for this, but by 8.0 we should look also into consistency responses. It seems weird that a failed auth returns {"error": "invalid token"}, but wrong method returns a whole

{
  "accepted": 0,
  "errors": [
    {
      "message": "only POST requests are supported"
    }
  ]
}

Particularly because a 405 obviously won't cause any events to be ingested

@graphaelli
Copy link
Member Author

@axw posting your notes here for safe keeping. Regarding options for moving todate_nanos @timestamp:

  • @timestamp as date_nanos with a default format of epoch_millis and a runtime field for <foo>.timestamp.us until we can move fully onto @timestamp.
  • UI uses the fields API to query @timestamp with format strict_date_optional_time_nanos, and also queries <foo>.timestamp.us and uses that if it exists. We would stop mapping and indexing the latter, this would just be for backwards compatibility

@axw
Copy link
Member

axw commented Aug 12, 2021

For discussion, some things I'd like to look at for 8.0:

  • remove index template, ILM policy, pipeline setup & related config -- move all setup to integration package
  • remove old index selector support, always create data streams (Introduce standalone data stream support, deprecate Elasticsearch setup #5914)
  • remove dedicated Jaeger port (now that we have it muxed on 8200)
  • align standalone config defaults with integration package
  • switch apm-server.sampling.keep_unsampled default to false
  • switch @timestamp to date_nanos (maybe add timestamp.us runtime field for backwards compatibility)
  • replace <event>.duration.us with event.duration (maybe add runtime fields for backwards compatibility)

@axw
Copy link
Member

axw commented Aug 17, 2021

Another thing just popped up while I was looking into our dependence on "classic indices": the original source mapping storage implementation. APM Server indexes and searches sourcemaps in apm-<version>-sourcemap.

Users can now upload sourcemaps to Kibana, but currently the only way APM Server can receive them is through Fleet. If we are going to maintain support for sourcemapping in standalone APM Server, we will need to have APM Server query Kibana for sourcemaps when running with data streams enabled.

@axw
Copy link
Member

axw commented Aug 18, 2021

Remove apm-server.instrumentation.* config -- replaced by instrumentation.* many releases ago.

@simitt
Copy link
Contributor

simitt commented Nov 3, 2021

closing this issue as we created tracking issues and labeled them 8.0 for everything we plan to implement.

@simitt simitt closed this as completed Nov 3, 2021
@zube zube bot removed the [zube]: Done label Feb 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants