decoder v2: remove unused modeldecoder code (#4363)

* remove unused code

* add targetType validation rule and apply for `context.request.url.port`

* add decoder tests for outcome and metadata client

* add decoder tests for metadata system

* add decoder tests for transaction marks

* move transform tests out of decoder package and to model

Author: simitt

NOTICE.txt

@@ -3404,40 +3404,6 @@ Contents of "LICENSE":
     OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
     SOFTWARE.
 
---------------------------------------------------------------------
-Dependency: github.com/santhosh-tekuri/jsonschema
-Version: v1.2.4
-License type (autodetected): BSD-3-Clause
-Contents of "LICENSE":
-
-    Copyright (c) 2017 Santhosh Kumar Tekuri. All rights reserved.
-
-    Redistribution and use in source and binary forms, with or without
-    modification, are permitted provided that the following conditions are
-    met:
-
-       * Redistributions of source code must retain the above copyright
-    notice, this list of conditions and the following disclaimer.
-       * Redistributions in binary form must reproduce the above
-    copyright notice, this list of conditions and the following disclaimer
-    in the documentation and/or other materials provided with the
-    distribution.
-       * Neither the name of Google Inc. nor the names of its
-    contributors may be used to endorse or promote products derived from
-    this software without specific prior written permission.
-
-    THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
-    "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
-    LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
-    A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
-    OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
-    SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
-    LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
-    DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
-    THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
-    (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
-    OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
-
 --------------------------------------------------------------------
 Dependency: github.com/Shopify/sarama
 Replacement: github.com/elastic/sarama

beater/middleware/request_metadata_middleware.go

@@ -27,8 +27,7 @@ import (
 func UserMetadataMiddleware() Middleware {
 	return func(h request.Handler) (request.Handler, error) {
 		return func(c *request.Context) {
-			dec := utility.ManualDecoder{}
-			c.RequestMetadata.UserAgent = dec.UserAgentHeader(c.Request.Header)
+			c.RequestMetadata.UserAgent = utility.UserAgentHeader(c.Request.Header)
 			c.RequestMetadata.ClientIP = utility.ExtractIP(c.Request)
 			h(c)
 		}, nil

model/context.go

@@ -188,8 +188,7 @@ func (h *Http) UserAgent() string {
 	if h == nil || h.Request == nil {
 		return ""
 	}
-	dec := utility.ManualDecoder{}
-	return dec.UserAgentHeader(h.Request.Headers)
+	return utility.UserAgentHeader(h.Request.Headers)
 }
 
 // Fields returns common.MapStr holding transformed data for attribute page.