fix: ensure clean state when packaging artifacts (#19252)

* fix: copy full repository in Docker build to guarantee clean VCS state

Go’s build process now automatically embeds VCS information into the
binary. When the repository contains untracked files or the working
tree is dirty, the binary receives a “dirty” flag, which can make it
look tampered, confuse security scanners, and break reproducible
builds.

This PR updates the Dockerfiles to copy the entire repository into the
build image and adds all tracked files to the Docker build context.
By ensuring the same source tree is used both inside and outside the
container, the resulting binary matches the locally‑built version and
the Git state remains clean.

* fix: add gvm to .gitignore

The CI packaging pipeline installs gvm directly in the workspace,
producing a gvm binary that isn’t tracked by Git. Because the file
is untracked, the repository appears dirty, causing Go to embed a
dirty flag in the VCS metadata of the built binary.

This change adds the generated gvm binary to .gitignore,
ensuring the Git tree stays clean and the resulting binary’s VCS
metadata reflects a pristine state.

* Update Dockerfile

* Update Dockerfile.fips

* Update Dockerfile.wolfi

(cherry picked from commit b74e01a)

Author: kruskall

.dockerignore

@@ -1,6 +1,3 @@
 /build
 /apm-server
-/systemtest
 /rally
-/docs
-/testdata

.gitignore

@@ -53,3 +53,4 @@ testing/smoke/**/main.tf
 !testing/smoke/managed/main.tf
 testing/rally-cloud/build
 .bck
+gvm

packaging/docker/Dockerfile

@@ -10,12 +10,7 @@ FROM golang:${GOLANG_VERSION} AS builder
 WORKDIR /src
 COPY go.mod go.sum /src/
 RUN --mount=type=cache,target=/go/pkg/mod go mod download
-COPY Makefile *.mk /src/
-COPY cmd /src/cmd
-COPY internal /src/internal
-COPY x-pack /src/x-pack
-COPY .git /src/.git
-COPY script /src/script
+COPY . .
 
 RUN --mount=type=cache,target=/go/pkg/mod \
     --mount=type=cache,target=/root/.cache/go-build \

packaging/docker/Dockerfile.fips

@@ -9,12 +9,7 @@ FROM docker.elastic.co/wolfi/go-msft-fips:${GOLANG_VERSION} as builder
 WORKDIR /src
 COPY go.mod go.sum /src/
 RUN --mount=type=cache,target=/root/go/pkg/mod go mod download
-COPY Makefile *.mk /src/
-COPY cmd /src/cmd
-COPY internal /src/internal
-COPY x-pack /src/x-pack
-COPY .git /src/.git
-COPY script /src/script
+COPY . .
 
 RUN --mount=type=cache,target=/root/go/pkg/mod \
     make apm-server-fips-msft

packaging/docker/Dockerfile.wolfi

@@ -9,12 +9,7 @@ FROM docker.elastic.co/wolfi/go:${GOLANG_VERSION} as builder
 WORKDIR /src
 COPY go.mod go.sum /src/
 RUN --mount=type=cache,target=/root/go/pkg/mod go mod download
-COPY Makefile *.mk /src/
-COPY cmd /src/cmd
-COPY internal /src/internal
-COPY x-pack /src/x-pack
-COPY .git /src/.git
-COPY script /src/script
+COPY . .
 
 RUN --mount=type=cache,target=/root/go/pkg/mod \
     --mount=type=cache,target=/root/.cache/go-build \