Ensure we always start an Activity even when OTelBridge disabled #2656
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The comments and previous implementation always started an activity for the transaction, even when the bridge is disabled. This enures we fix the regression in the behaviour. This also ensures we only stop the Activity is we started it, which logically feels correct.
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The comments and previous implementation always started an activity for the transaction, even when the bridge is disabled. This enures we fix the regression in the behaviour.
This also ensures we only stop the Activity is we started it, which logically feels correct.
Fixes #2654