Improve OTel bridge compatibility with existing Azure instrumentation #2455
Conversation
stevejgordon
force-pushed
the
fix-servicebus-instrumentation
branch
from
81c9681 to
7854d2d
Compare
| // This simply ensures our transaction activity is always created. | ||
| internal static readonly ActivityListener Listener = new() | ||
| { | ||
| ShouldListenTo = s => s.Name == ElasticApmActivitySource.Name, | ||
| Sample = (ref ActivityCreationOptions<ActivityContext> _) => ActivitySamplingResult.AllData | ||
| }; |
There was a problem hiding this comment.
@stevejgordon @Mpdreamz Sorry to revive this, but the Listener is never registered via ActivitySource.AddActivityListener(Listener);, so the intended behavior (per the comment) isn't actually correct.
This issue (activities not being created) is hidden when OpenTelemetryBridgeEnabled is true (the default), since ElasticActivityListener registers a listener for all ActivitySources. But if the bridge is disabled then no activity is created.
There was a problem hiding this comment.
Thanks for highlighting this @aheubusch. Is this manifesting in an error or issue for you? I think the intent was focused on the scenario where the bridge is in use, but it's complex code and there may be knock on effects we didn't consider.
There was a problem hiding this comment.
No error or issue in my application (bridge is enabled). One of my unit tests (bridge is disabled) started failing after an update from 1.28 to 1.34 because it assumed that StartTransaction always creates an Activity (except when ignoreActivity=true).
In general this change in behavior appears to be unintentional, so I wanted to raise it.
This ensures that the Azure SDK instrumentation doesn't use the existing
Activityspan ID, which, when combined with the OTel bridge, can lead to spans being parented by themselves.This also enhances the logic of the OTel bridge so that we skip span creation for activities coming from the Azure SDK libraries if our Azure instrumentation assemblies are loaded. This ensures we don't create essentially repeated child spans.
Fixes #2452