Skip to content

bolt11 #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ekzyis merged 89 commits into from
Jan 3, 2026
Merged

bolt11 #2

ekzyis merged 89 commits into from
Jan 3, 2026

Conversation

@ekzyis
Copy link
Owner

@ekzyis ekzyis commented Dec 18, 2025

No description provided.

@ekzyis
Copy link
Owner Author

ekzyis commented Dec 18, 2025

image

@ekzyis ekzyis force-pushed the bolt11 branch 7 times, most recently from 7903a50 to 5fba195 Compare December 24, 2025 15:04
@ekzyis
Copy link
Owner Author

ekzyis commented Jan 2, 2026

What I learned, in no specific order, without any judgement:

  1. There's no test for valid invoices with n (public key of payee node) as a tagged field1
  2. payment_secret is important. Without it, all forwarding nodes could steal overpaid amount by probing the destination first with less.
  3. You need to partially implement bolt09 to implement bolt11
  4. Links between BOLTs can be confusing because of inconsistencies, historical artifacts, spec vs real-life etc.
  5. The spec is not as clear as I expected it to be, but I also don't have a lot of experience with implementing network protocol spec, only with two cipher specs (ChaCha20 and NIP-44). I was quite surprised by how "patched together" it read.
  6. high-S vs low-S signatures
  7. public key recovery
  8. bech32 encoding
  9. LND's bolt11 implementation

Footnotes

  1. I'm considering to contribute one ↩

@ekzyis ekzyis force-pushed the bolt11 branch 2 times, most recently from 0143982 to 3418dc4 Compare January 3, 2026 13:20
@ekzyis ekzyis force-pushed the develop branch 2 times, most recently from d179799 to dcd5853 Compare January 3, 2026 13:31
ekzyis added 16 commits January 3, 2026 14:38
@ekzyis
Pass first bolt11 test vector
579e7ef
@ekzyis
Refactor with Hash.IsZero()
f0db016
@ekzyis
Declare test constants outside of test case
5d2ecb4
@ekzyis
Pass 2nd test vector with expiry
792282d
@ekzyis
Pass 3rd test vector with katakana and kanji chars
0187dc3
@ekzyis
Make amounts easier to read with underscores
04bc171
@ekzyis
Pass 4th test vector with long description (200 bytes)
c109f2f
@ekzyis
Add test descriptions
a70be9b
@ekzyis
Order missing tagged fields last
478249c
@ekzyis
Add other encode/decode tests with valid data but skip for now
9c403e9
@ekzyis
Decode base58 address mk2QpYatsKicvFVuTAQLBryyccRXMUaGHP
863ef34
@ekzyis
Throw ErrNotImplemented instead of returning nil
8a3b576
@ekzyis
Consistent order of Encode, EncodeBase32 methods
c3c4db1
@ekzyis
P2PKH encoding for bolt11 tagged fields
f49fa0b
@ekzyis
Create Bolt11Encoder interface
ffbbb6a
@ekzyis
Remove TODO about fallback address support
0144d88
ekzyis added 25 commits January 3, 2026 14:38
@ekzyis
Decode routing hints
462575c
@ekzyis
Decode min_final_cltv_expiry_delta
2e34c66
@ekzyis
Use errInvalidWitnessVersion
263eedf 
Unfortunately, using dedicated errors means that I can't include additional
information in the error message. Mhh.
@ekzyis
Pass decode test for upper case bech32 encoded pr
12241b6
@ekzyis
Skip over f fields with unknown version
eb6f22b
@ekzyis
Skip over unknown tagged fields
df9c49c
@ekzyis
Skip confusing test
dac08c0
@ekzyis
Rename to secp256k1.go
0b89584
@ekzyis
Move Signer implementation for tests into secp256k1 package
b1a96a8
@ekzyis
Verify signature during decoding
d32b02c
@ekzyis
Fully specify generated signatures in comments
92a53a5
@ekzyis
Pass test with high-S signature
6042c5e
@ekzyis
Rename tests
9a58a52
@ekzyis
Throw error on encoding/decoding unknown, required feature bits
cda0293
@ekzyis
Declare all bech32 versions as const
d7fbbb7
@ekzyis
Pass test with invalid bech32 checksum
6da0152
@ekzyis
Pass test with malformed bech32 string (no 1)
869b786
@ekzyis
Pass test with malformed bech32 string (mixed case)
d2b6271
@ekzyis
Pass test with unrecoverable signature
9c7e757
@ekzyis
Pass test with too short bech32 string
78f0df4
@ekzyis
Pass test with invalid multiplier
00ec62f
@ekzyis
Pass test with invalid sub-millisatoshi precision
85031c4
@ekzyis
Pass test with missing s field
dc107ec
@ekzyis
Fix test of pr defaults
9bba989
@ekzyis
Also validate in NewPaymentRequest()
2ff277c
@ekzyis ekzyis merged commit fe43916 into develop Jan 3, 2026
@ekzyis ekzyis deleted the bolt11 branch January 3, 2026 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ekzyis