Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Program crash, probably parsing issue #3

Open
simion314 opened this issue Dec 6, 2023 · 1 comment
Open

Program crash, probably parsing issue #3

simion314 opened this issue Dec 6, 2023 · 1 comment

Comments

@simion314
Copy link

Hi, so I am getting this errors. It seems to be some parsing error, so maybe you need more error checking but I might be wrong. I used llama2 13b gguf

start_game("London, 1660")
You are in your room in the Lamb and Flag Inn. Behind you is a window. Ahead of you is a door to the hallway. To your left is a desk and the bed. On the desk is your rapier. To your right is a dresser and the fireplace.
Scene('lamb_and_flag_room_1', behind=[WallFeature('window', width=1)], ahead=[WallFeature('door', width=1)], left=[Feature('desk', dist_from_wall=1, width_along_wall=2, depth=1), Item('rapier', on='desk'), Feature('bed', dist_from_wall=0, width_along_wall=3, depth=2)], right=[Feature('dresser', dist_from_wall=0, width_along_wall=2, depth=1), WallFeature('fireplace', width=2)])
inventory
Inventory([(Item('pence'), 2)])
take('rapier')
You pick up your rapier.
InventoryChange([(Item('rapier'), 1)])
go('door', 'ahead')
You are in the hallway of the Lamb and Flag Inn. Behind is the door to your room. To your left is a door leading to the tavern. In front of you is the entrance to the dining room. Ahead of you is a staircase going up. On the right are the stairs leading down to the basement. There is another guest here.
Scene('lamb_and_flag_hallway', behind=[WallFeature('door', width=1)], left=[WallFeature('door', width=1)], ahead=[WallFeature('staircase_up', width=1), WallFeature('hallway_door', width=1)], right=[Feature('stairs_down', dist_from_wall=0, width_along_wall=1, depth=3), Person('gentleman', at='stairs_down')])
say('Good morrow to you, sir', to='gentleman')
"And a good morrow to you as well, my dear sir."
go('door', 'left')
You are in the Lamb and Flag Inn's tavern. Behind you is the door to the hallway. To your right are two large tables with people playing cards at them. In front of you, across from the tables, is a bar with a sign that says "Bar." To your left is the door to the street and another table of men playing cards and talking. Behind the bar is a fireplace.
Scene('tavern', behind=[WallFeature('door', width=1)], right=[Feature('table1', dist_from_wall=2, width_along_wall=4, depth=2), Item('cards', on='table1'), People(3, 'adult male', at='table1'), Feature('table2', dist_from_wall=2, width_along_wall=4, depth=2), Item('cards', on='table2'), People(3, 'adult male', at='table2')], ahead=[WallFeature('fireplace', width=2), Feature('bar', dist_from_wall=2, in_front_of='fireplace', width_along_wall=4, depth=1), Person('bartender', at='bar'), Item('sign', on='bar')], left=[WallFeature('door', width=1), Feature('table3', dist_from_wall=1, width_along_wall=7, depth=3), Item('cards', on='table3'), People(3, 'adult male', at='table3')])

Traceback (most recent call last):
File "/giant/APPS/AI/textadventure/llama-journey/game.py", line 1232, in
main()
File "/giant/APPS/AI/textadventure/llama-journey/game.py", line 1228, in main
curses.wrapper(lambda stdscr: curses_main(stdscr, inference_proc))
File "/usr/lib/python3.10/curses/init.py", line 94, in wrapper
return func(stdscr, *args, **kwds)
File "/giant/APPS/AI/textadventure/llama-journey/game.py", line 1228, in
curses.wrapper(lambda stdscr: curses_main(stdscr, inference_proc))
File "/giant/APPS/AI/textadventure/llama-journey/game.py", line 1191, in curses_main
state.handle(inference_proc.get_last_object(), '\n'.join(inference_proc.get_last_messages()))
File "/giant/APPS/AI/textadventure/llama-journey/game.py", line 810, in get_last_object
return next(self.get_last_objects(), *default_arg)
File "/giant/APPS/AI/textadventure/llama-journey/game.py", line 803, in get_last_objects
obj = self._eval(lines[i])
File "/giant/APPS/AI/textadventure/llama-journey/game.py", line 748, in _eval
return eval(code, {'builtins': {}, **self._eval_globals})
File "", line 1, in
TypeError: Feature.init() got an unexpected keyword argument 'at'

@ejones
Copy link
Owner

ejones commented Dec 6, 2023

Yes, I could see that. It looks like this occurred when you moved through a door or something? Do you mind trying again and seeing if this happens consistently? The model should generally be constrained to valid outputs, but it's not perfect and I do see the occasional crash. The catch-all would be a retry mechanism but I haven't implemented that yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants