Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should not auto-merge if title changes #6

Open
axic opened this issue Jul 4, 2019 · 3 comments
Open

Should not auto-merge if title changes #6

axic opened this issue Jul 4, 2019 · 3 comments

Comments

@axic
Copy link
Contributor

axic commented Jul 4, 2019

No description provided.

@Arachnid
Copy link
Collaborator

Arachnid commented Jul 5, 2019

Why not?

@axic
Copy link
Contributor Author

axic commented Jul 7, 2019

Because that is likely a "material change". It would be nice to allow pretty much any change, but "material" changes should require a review.

@Arachnid
Copy link
Collaborator

We're trying to limit the amount of manual review editors have to do, though. Is it likely we'd reject a PR with a changed title, or will we just end up rubber-stamping them all?

@Ajorgens1 Ajorgens1 mentioned this issue Jan 18, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Arachnid @axic and others