Sync option unchecked even when sync is enabled

[FranklinYu]

To reproduce, make sure that rules are few enough; I have only two short ones. Just check the “Enable Storage Sync” and see the notification “Sync is enabled!” now refresh the page. The checkbox become un-checked again.

Issue is at

Redirector/js/redirectorpage.js

Line 46 in 0772e59

el('#storage-sync-option').checked = options.isSyncEnabled;

It is checking #storage-sync-option, which is a label, not an input; see

Redirector/redirector.html

Line 198 in 0772e59

<label id="storage-sync-option"><input type="checkbox" /> Enable Storage Sync</label>

I guess simply appending input to the selector would work.

[einaregilsson]

Ah, you're right. I'll fix it for the next version, thanks!

[arrmo]

Same issue here - appreciate you fixing this, thanks! How to know when it is updated (Github is easy, but Chrome?).

[FranklinYu]

@arrmo I don’t think we have any notification for extension update. Best way so far is to check version daily after this issue is closed.

[arrmo]

No worries, completely understand. I'll keep an eye on this item - when it closes, then will check the extension (every few days).

Thanks!!

[arrmo]

Hi,

Not seeing this one "pushed" to a formal release - or am I just missing it? Would be helpful, just so sync status shows correctly.

Thanks!

[einaregilsson]

I just haven't made a release yet 🙂. I'll try to get one out soon.

[arrmo]

No worries, fully understand. Appreciate it!

[arrmo]

Sorry, just checking back in 😆. Thanks!!!

[arrmo]

Hi,

Looks like there is a PR to address this now?

Thanks!

[Gitoffthelawn]

@Arro Yes, there is!

There are some things going on that have delayed pull requests being integrated. Hopefully they can be integrated soon.

[arrmo]

Sounds great, thanks!

[g-a-c]

There are some things going on that have delayed pull requests being integrated.

I'm curious, @Gitoffthelawn do you have access to merge PRs?

[Gitoffthelawn]

@g-a-c Not at the moment, but we are working to make that happen.

[g-a-c]

Cool, I wasn't sure what a state this repository was in after the events of this year. There will need to be an issue addressed with the extension manifests, because this extension still uses manifest v2, and v2 will be phased out in Jan 2023. But I wasn't sure whether it was better to open an issue in here or to fork the project and take a look into fixing it myself. If it's possible for someone other than the original author to have merge permissions then addressing it here makes much more sense though to benefit everyone.

[Gitoffthelawn]

@g-a-c Sounds good. I was just going to create an issue regarding manifest v2 and v3, but I see you just created one: #316. Thanks! Let's continue our discussion on manifests there.

[arrmo]

Hi,

Checking back in 😆. Any luck getting this one "pushed out"?

Thanks!

[arrmo]

Thanks! Does this need to be pushed, to show up in Google Chrome?

[Gitoffthelawn]

@Armo You're welcome!

Yes, I'm just waiting for full access so we can proceed.

Please see #329 and Gitoffthelawn/Contact-Gitoffthelawn#8.