Skip to content

Commit 23b07af

Browse files
committed
fix: renderize only if necessary
1 parent 2cc506a commit 23b07af

File tree

1 file changed

+35
-21
lines changed

1 file changed

+35
-21
lines changed

lib/sidecar/grpc/generators/handler_transcoding_generator.ex

+35-21
Original file line numberDiff line numberDiff line change
@@ -15,26 +15,27 @@ defmodule Sidecar.GRPC.Generators.HandlerTranscodingGenerator do
1515
def template do
1616
"""
1717
defmodule <%= @module %>.ActorDispatcher do
18-
use GRPC.Server, service: <%= @service_name %>.Service, http_transcode: true
19-
20-
alias Sidecar.GRPC.Dispatcher
21-
22-
<%= for {method_name, input, output, _options} <- @methods do %>
23-
@spec <%= Macro.underscore(method_name) %>(<%= input %>.t(), GRPC.Server.Stream.t()) :: <%= output %>.t()
24-
def <%= Macro.underscore(method_name) %>(message, stream) do
25-
request = %{
26-
system: <%= inspect(@actor_system) %>,
27-
actor_name: <%= inspect(@actor_name) %>,
28-
action_name: <%= inspect(method_name) %>,
29-
input: message,
30-
stream: stream,
31-
descriptor: <%= @service_name %>.Service.descriptor()
32-
}
33-
34-
Dispatcher.dispatch(request)
35-
end
18+
<%= if @render do %>
19+
use GRPC.Server, service: <%= @service_name %>.Service, http_transcode: true
20+
21+
alias Sidecar.GRPC.Dispatcher
22+
23+
<%= for {method_name, input, output, _options} <- @methods do %>
24+
@spec <%= Macro.underscore(method_name) %>(<%= input %>.t(), GRPC.Server.Stream.t()) :: <%= output %>.t()
25+
def <%= Macro.underscore(method_name) %>(message, stream) do
26+
request = %{
27+
system: <%= inspect(@actor_system) %>,
28+
actor_name: <%= inspect(@actor_name) %>,
29+
action_name: <%= inspect(method_name) %>,
30+
input: message,
31+
stream: stream,
32+
descriptor: <%= @service_name %>.Service.descriptor()
33+
}
34+
35+
Dispatcher.dispatch(request)
36+
end
37+
<% end %>
3638
<% end %>
37-
3839
end
3940
"""
4041
end
@@ -44,9 +45,21 @@ defmodule Sidecar.GRPC.Generators.HandlerTranscodingGenerator do
4445
do_generate(ctx, svcs)
4546
end
4647

47-
defp do_generate(_ctx, nil), do: {"unknown", []}
48+
defp do_generate(_ctx, nil),
49+
do:
50+
{"unknown",
51+
[
52+
render: false,
53+
module: "unknown"
54+
]}
4855

49-
defp do_generate(_ctx, []), do: {"unknown", []}
56+
defp do_generate(_ctx, []),
57+
do:
58+
{"unknown",
59+
[
60+
render: false,
61+
module: "unknown"
62+
]}
5063

5164
defp do_generate(ctx, svcs) do
5265
for svc <- svcs do
@@ -69,6 +82,7 @@ defmodule Sidecar.GRPC.Generators.HandlerTranscodingGenerator do
6982

7083
{mod_name,
7184
[
85+
render: true,
7286
module: mod_name,
7387
actor_system: actor_system,
7488
actor_name: actor_name,

0 commit comments

Comments
 (0)