Fonts that were downloaded via the website strips the PS Private dict #69
Comments
|
Must be an OpenType.js issue. |
|
The problem also exists if one downloads the release zip archive from https://github.com/eigilnikolajsen/commit-mono/releases/tag/v1.143 Is there a recommended way to get an intact font file?
|
|
These file contains the blues, maybe that was meant by AnggaSP
while the zip archive in-repo also has fonts without blues...; this does not contain blues:
Strangeness. |
|
There are even more astonishing differences. Here I compare the $ ls -l
total 5352
-rw-r--r-- 1 fini fini 274752 Aug 29 13:15 CommitMono-400-Regular.otf
-rw-rw-r-- 1 fini fini 161124 Aug 29 13:14 CommitMonoV143-400Regular.otf
$ ttx C*
...
$ ls -l
total 5352
-rw-r--r-- 1 fini fini 274752 Aug 29 13:15 CommitMono-400-Regular.otf
-rw-rw-r-- 1 fini fini 2660722 Aug 29 13:24 CommitMono-400-Regular.ttx
-rw-rw-r-- 1 fini fini 161124 Aug 29 13:14 CommitMonoV143-400Regular.otf
-rw-rw-r-- 1 fini fini 2373405 Aug 29 13:24 CommitMonoV143-400Regular.ttx
$ diff -u CommitMono-400-Regular.ttx CommitMonoV143-400Regular.ttxThe diff colored, <head>
<!-- Most of this table will be recalculated by the compiler -->
<tableVersion value="1.0"/>
- <fontRevision value="1.0"/>
- <checkSumAdjustment value="0xebc3c57b"/>
+ <fontRevision value="1.14299"/>
+ <checkSumAdjustment value="0xa7a818a8"/>
<magicNumber value="0x5f0f3cf5"/>
<flags value="00000000 00000011"/>
<unitsPerEm value="1000"/>
- <created value="Thu Dec 28 09:00:29 2023"/>
- <modified value="Thu Dec 28 09:00:29 2023"/>
+ <created value="Sun Jun 11 09:40:24 2023"/>
+ <modified value="Thu Dec 28 08:58:15 2023"/>
<xMin value="-120"/>
<yMin value="-500"/>
<xMax value="1644"/>
@@ -1964,9 +1964,9 @@
<descent value="-200"/>
<lineGap value="0"/>
<advanceWidthMax value="600"/>
- <minLeftSideBearing value="30"/>
- <minRightSideBearing value="-918"/>
- <xMaxExtent value="1794"/>
+ <minLeftSideBearing value="-120"/>
+ <minRightSideBearing value="-1044"/>
+ <xMaxExtent value="1644"/>
<caretSlopeRise value="1"/>
<caretSlopeRun value="0"/>
<caretOffset value="0"/>
@@ -1975,7 +1975,7 @@
<reserved2 value="0"/>
<reserved3 value="0"/>
<metricDataFormat value="0"/>
- <numberOfHMetrics value="1932"/>
+ <numberOfHMetrics value="1"/>
</hhea>
<maxp>
@@ -2003,23 +2003,23 @@
<yStrikeoutPosition value="324"/>
<sFamilyClass value="0"/>
<panose>
- <bFamilyType value="0"/>
- <bSerifStyle value="0"/>
- <bWeight value="0"/>
- <bProportion value="0"/>
- <bContrast value="0"/>
- <bStrokeVariation value="0"/>
- <bArmStyle value="0"/>
- <bLetterForm value="0"/>
- <bMidline value="0"/>
- <bXHeight value="0"/>
+ <bFamilyType value="2"/>
+ <bSerifStyle value="11"/>
+ <bWeight value="8"/>
+ <bProportion value="9"/>
+ <bContrast value="2"/>
+ <bStrokeVariation value="2"/>
+ <bArmStyle value="2"/>
+ <bLetterForm value="2"/>
+ <bMidline value="2"/>
+ <bXHeight value="4"/>
</panose>
<ulUnicodeRange1 value="10000000 00000000 00000000 10100111"/>
<ulUnicodeRange2 value="00010000 00000000 00111001 11110011"/>
<ulUnicodeRange3 value="00000000 00000100 00000000 00100000"/>
<ulUnicodeRange4 value="00000000 00000000 00000000 00000000"/>
<achVendID value=" "/>
- <fsSelection value="00000000 00000000"/>
+ <fsSelection value="00000000 11000000"/>
<usFirstCharIndex value="0"/>
<usLastCharIndex value="65533"/>
<sTypoAscender value="900"/>
@@ -2033,48 +2033,45 @@
<sCapHeight value="700"/>
<usDefaultChar value="0"/>
<usBreakChar value="32"/>
- <usMaxContext value="0"/>
+ <usMaxContext value="7"/>
</OS_2>
<name>
...Analysis of diff:
Lets have a look at the small letter - <mtx name="a" width="600" lsb="30"/>
+ <mtx name="a" width="600" lsb="81"/>How could the lsb be different? At least when read by Glyphs3 both font have the same lsb for letter a, see image below - I do not know where this comes from, a ttx bug? Later: Ah maybe that is due to the nice "smart kerning" feature And this...
Maybe @eigilnikolajsen can shed some light on this. What are the different fonts, which is supposed to be 'the' release font? A guessWhat I guess is that the font has been created with Fontlab. The fonts in the |
|
Thank you for this. |
|
Ah now I see how you do it ...
Respect! I could not put everything into the website like this. At least this answers what are the "real" files, as the website also loads the font that are in the fontlab directory: I can try to help out here. Is there a repo for the website? |
|
It is indeed a problem of First I tried to update it to current master (which has many unreleased fixes, notably adding CFF2 which in principle should support the missing blue values in PS private.) And at least it reads them now correctly (with some help from my side):
But there is still a problem to write |
|
To not forget my changes in Wrong version used in parsingThere are multiple versions in a font, meaning the version of the header standard. -- /home/ujastrow/git/opentype.js/dist/opentype.js 2024-09-04 11:44:38.794842197 +0200
+++ opentype.git.js 2024-09-04 15:30:41.782125178 +0200
@@ -6575,7 +6575,7 @@
const privateSize = version < 2 ? topDict.private[0] : 0;
const privateOffset = version < 2 ? topDict.private[1] : 0;
if (privateSize !== 0 && privateOffset !== 0) {
- const privateDict = parseCFFPrivateDict(data, privateOffset + start, privateSize, strings, version);
+ const privateDict = parseCFFPrivateDict(data, privateOffset + start, privateSize, strings, 2);
topDict._defaultWidthX = privateDict.defaultWidthX;
topDict._nominalWidthX = privateDict.nominalWidthX;
if (privateDict.subrs !== 0) {
@@ -7272,7 +7272,7 @@
}
if (header.formatMajor < 2) {
const privateDictOffset = start + topDict.private[1];
- const privateDict = parseCFFPrivateDict(data, privateDictOffset, topDict.private[0], stringIndex.objects, header.formatMajor);
+ const privateDict = parseCFFPrivateDict(data, privateDictOffset, topDict.private[0], stringIndex.objects, 2);
font.defaultWidthX = privateDict.defaultWidthX;
font.nominalWidthX = privateDict.nominalWidthX;
if (privateDict.subrs !== 0) {Font generationThe tables collected by the parsing is not used, they actually fail to fill this. --- /home/ujastrow/git/opentype.js/dist/opentype.js 2024-09-04 11:44:38.794842197 +0200
+++ opentype.git.js 2024-09-04 15:30:41.782125178 +0200
@@ -7534,7 +7534,7 @@
attrs.paintType = topDictOptions.paintType;
attrs.strokeWidth = topDictOptions.strokeWidth || 0;
}
- const privateAttrs = {};
+ const privateAttrs = topDictOptions._privateDict || {};
const glyphNames = [];
let glyph;
for (let i = 1; i < glyphs.length; i += 1) {
@@ -7549,7 +7549,13 @@
t.globalSubrIndex = makeGlobalSubrIndex();
t.charsets = makeCharsets(glyphNames, strings);
t.charStringsIndex = makeCharStringsIndex(glyphs, cffVersion);
- t.privateDict = makePrivateDict(privateAttrs, strings);
+ t.privateDict = makePrivateDict(privateAttrs, strings, 2);
t.stringIndex = makeStringIndex(strings);
const startOffset = t.header.sizeOf() + t.nameIndex.sizeOf() + t.topDictIndex.sizeOf() + t.stringIndex.sizeOf() + t.globalSubrIndex.sizeOf();
attrs.charset = startOffset;Remaining issuesThis can of course be wrong, these are just my ideas at the moment. There is no implementation it seems to translate And the whole font generation fails if there are |
|
Dear @eigilnikolajsen
The last days I looked into I am not sure if or when they will pull them, but for your font distribution it would be beneficial. I would suggest that you use instead of (your anyhow own-hosted) The change is simple for you (just exchange that one file) and the only thing needed for you is cloning my PR and running Of course the default / Gitlab release font will then also change (i.e. be fixed). It would be nice if that happens before the next NerdFont release (end September) so we can already incorporate it. Cheers, Fini |
Description:
It seems the font customization strips the PS Private? See this Image:
This affects postscript hinting on mac and more importantly, this prevents afdko/otfautohint from running.
The text was updated successfully, but these errors were encountered: