Skip to content

Commit a079b4c

Browse files
committed
Issue #145, Minor issues fixed
1 parent 11a801d commit a079b4c

File tree

6 files changed

+20
-7
lines changed

6 files changed

+20
-7
lines changed

eiffel-vocabulary/EiffelTestCaseFinishedEvent.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -60,12 +60,12 @@ __Description:__ A list of metrics collected during the test case execution. Not
6060

6161
##### data.outcome.metrics.name
6262
__Type:__ String
63-
__Required:__ No
63+
__Required:__ Yes
6464
__Description:__ The metrics name.
6565

6666
##### data.outcome.metrics.value
6767
__Type:__ Any
68-
__Required:__ No
68+
__Required:__ Yes
6969
__Description:__ The metrics value.
7070

7171
### data.persistentLogs

eiffel-vocabulary/EiffelTestExecutionRecipeCollectionCreatedEvent.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ How the test selection service generates the recipe collection is, from the poin
2424

2525
The __data__ object consists of two main parts. __data.selectionStrategy__ identifies the strategy used to select the test cases and generate the recipe collection, while __data.batches__ or __data.batchesUri__ contain or reference, respectively, the recipes. The recipes are grouped in batches, which are used to control the order of execution of test cases. Every batch has a priority to let the test executor order them in sequence, but within each batch no assumptions are made as to the execution order the test cases. This way the recipe collection can either allow the executor a high degree of freedom in scheduling the test executions, and/or prescribe the exact sequential order in which they must be executed. Each event SHALL include one and only one of __data.batches__ and __data.batchesUri__.
2626

27-
Finally, each recipe (__data.batches.recipes__) consists of two parts: the test case to execute, and the constraints of that execution. The EiffelTestExecutionRecipeCollectionCreatedEvent does control the syntax of these constraints, as the nature of such constraints are highly dependent on technology domain and test execution framework. That being said, there are three questions that typically need to be answered: what is the item under test, in what kind of environment is it to be tested, and what are the test parameters? Note the distinction between test case and test execution: it is perfectly legal for a single test case to appear multiple times within the same EiffelTestExecutionRecipeCollectionCreatedEvent, but (presumably) with different constraints.
27+
Finally, each recipe (__data.batches.recipes__) consists of two parts: the test case to execute, and the constraints of that execution. The EiffelTestExecutionRecipeCollectionCreatedEvent does not control the syntax of these constraints, as the nature of such constraints are highly dependent on technology domain and test execution framework. That being said, there are three questions that typically need to be answered: what is the item under test, in what kind of environment is it to be tested, and what are the test parameters? Note the distinction between test case and test execution: it is perfectly legal for a single test case to appear multiple times within the same EiffelTestExecutionRecipeCollectionCreatedEvent, but (presumably) with different constraints.
2828

2929
## Data Members
3030
### data.selectionStrategy

schemas/EiffelActivityTriggeredEvent/1.0.0.json

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -113,7 +113,14 @@
113113
"type": "object",
114114
"properties": {
115115
"type": {
116-
"type": "string"
116+
"type": "string",
117+
"enum": [
118+
"MANUAL",
119+
"EIFFEL_EVENT",
120+
"SOURCE_CHANGE",
121+
"TIMER",
122+
"OTHER"
123+
]
117124
},
118125
"description": {
119126
"type": "string"

schemas/EiffelTestCaseTriggeredEvent/1.0.0.json

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -129,7 +129,14 @@
129129
"type": "object",
130130
"properties": {
131131
"type": {
132-
"type": "string"
132+
"type": "string",
133+
"enum": [
134+
"MANUAL",
135+
"EIFFEL_EVENT",
136+
"SOURCE_CHANGE",
137+
"TIMER",
138+
"OTHER"
139+
]
133140
},
134141
"description": {
135142
"type": "string"

schemas/EiffelTestExecutionRecipeCollectionCreatedEvent/1.0.0.json

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -163,8 +163,7 @@
163163
},
164164
"required": [
165165
"id",
166-
"testCase",
167-
"constraints"
166+
"testCase"
168167
],
169168
"additionalProperties": false
170169
}

0 commit comments

Comments
 (0)