migration from gradle to maven #20
Conversation
| .project | ||
| .settings/ | ||
| .settings/ | ||
| /target/ |
There was a problem hiding this comment.
yes we are ignoring these folder while pushing to git from local
index.md
Outdated
| # PRI | ||
| The versions are indicated by a version identification of N.0.X. This shall be read as the actually released version of the Artifact in the ARM is the version N.0 with the highest X. Once a release has been made, N is stepped to N+1. | ||
|
|
||
| ## 0.0.X |
There was a problem hiding this comment.
check the version and update it properly here
There was a problem hiding this comment.
there is no need of this file you can remove it, anyway we are maintaining changelog.md file
pom.xml
Outdated
| <source>1.8</source> | ||
| <target>1.8</target> | ||
| <fork>true</fork> | ||
| <executable>C:\Program Files\Java\jdk1.8.0_151\bin\javac</executable> |
There was a problem hiding this comment.
remove the executable dependecy of local file system. Is it required at all ??
pom.xml
Outdated
| @@ -0,0 +1,43 @@ | |||
| <?xml version="1.0" encoding="UTF-8"?> | |||
| <project | |||
| xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd" | |||
There was a problem hiding this comment.
remove tabs and replace with 4 spaces in this file
pom.xml
Outdated
| <dependency> | ||
| <groupId>commons-codec</groupId> | ||
| <artifactId>commons-codec</artifactId> | ||
| <version>1.10</version> |
There was a problem hiding this comment.
Please use global properties for version declaration
pom.xml
Outdated
| <scope>compile</scope> | ||
| </dependency> | ||
| <dependency> | ||
| <groupId>commons-codec</groupId> |
There was a problem hiding this comment.
Please check, are we using this functionality? if not please remove this
There was a problem hiding this comment.
yes we are not using these dependency. we can remove
pom.xml
Outdated
| <properties> | ||
| <junit.version>4.12</junit.version> | ||
| <google-gson.version>2.8.1</google-gson.version> | ||
| <commons-codec.version>1.10</commons-codec.version> |
There was a problem hiding this comment.
remove unused version declaration.
pom.xml
Outdated
| </plugins> | ||
| </build> | ||
| <dependencies> | ||
| <dependency> |
There was a problem hiding this comment.
This one also we can remove,
Only one class we are using JsonParser from this library, in VersionService.java.
and it is a just Object declaration, so please remove
pom.xml
Outdated
| <plugins> | ||
| <plugin> | ||
| <artifactId>maven-compiler-plugin</artifactId> | ||
| <version>3.1</version> |
6 participants
Migrated from gradle to maven.