remove alternate TradeUI

The only thing this did was making trade UI categories collapsible. However, due to constant updates by the game devs in this menu, it has repeatedly blocked/broken other features and led to negative user feedback, so it feels like it's time to retire this from the mod. It was originally hoped that this change would be implemented in the base game, but that never happened.

Author: egocarib

Concepts/Options.cs

@@ -21,7 +21,6 @@ public static class UI
             public static bool UseSpriteMenu => GetOption("QudUX_OptionCustomSpriteMenu").EqualsNoCase("Yes") || string.IsNullOrEmpty(GetOption("QudUX_OptionCustomSpriteMenu"));
             public static bool ViewItemValues => GetOption("QudUX_OptionValPerLbInInventory").EqualsNoCase("Yes") || string.IsNullOrEmpty(GetOption("QudUX_OptionValPerLbInInventory"));
             public static bool ViewInventoryTiles => GetOption("QudUX_OptionShowInventoryTiles").EqualsNoCase("Yes") || string.IsNullOrEmpty(GetOption("QudUX_OptionShowInventoryTiles"));
-            public static bool CollapsibleTradeUI => GetOption("QudUX_OptionCollapseInTradeMenu").EqualsNoCase("Yes") || string.IsNullOrEmpty(GetOption("QudUX_OptionCollapseInTradeMenu"));
             public static bool AddConversationTiles => GetOption("QudUX_OptionTileConversationUI").EqualsNoCase("Yes") || string.IsNullOrEmpty(GetOption("QudUX_OptionTileConversationUI"));
             public static bool ShowAbilityDescriptions => GetOption("QudUX_OptionAbilityDescriptions").EqualsNoCase("Yes") || string.IsNullOrEmpty(GetOption("QudUX_OptionAbilityDescriptions"));
             public static bool EnableAutogetExclusions => GetOption("QudUX_OptionAutogetExclusions").EqualsNoCase("Yes") || string.IsNullOrEmpty(GetOption("QudUX_OptionAutogetExclusions"));

Harmony Patches/Patch_XRL_UI_TradeUI.cs

@@ -4,7 +4,6 @@
 using XRL.World.Parts;
 using GameOptions = XRL.UI.Options;
 using QudUXOptions = QudUX.Concepts.Options;
-using QudUXTradeUI = XRL.UI.QudUX_DummyTradeNamespace.TradeUI;
 
 namespace QudUX.HarmonyPatches
 {
@@ -21,32 +20,4 @@ public static void Prefix(GameObject Trader)
             QudUX_ConversationHelper.SetTraderInteraction(Trader);
         }
     }
-
-    /// <summary>
-    /// This patch is likely only temporary - it enables collapsible TradeUI sections. I have submitted this
-    /// for inclusion in the base game, so if that happens, I'll remove this patch & feature from QudUX.
-    /// </summary>
-    [HarmonyPatch(typeof(TradeUI))]
-    public static class Patch_XRL_UI_TradeUI_2
-    {
-        [HarmonyPrefix]
-        [HarmonyPatch("ShowTradeScreen")]
-        public static bool Prefix(GameObject Trader, float _costMultiple, TradeUI.TradeScreenMode screenMode)
-        {
-            if (GameOptions.OverlayPrereleaseTrade)
-            {
-                return true; //patch method not compatible with overlay trade UI
-            }
-            if (!QudUXOptions.UI.CollapsibleTradeUI)
-            {
-                return true; //user has disabled this feature
-            }
-            if (GameOptions.SifrahHaggling)
-            {
-                return true; //not currently compatible with chaos's sifrah haggling stuff (would require some work incorporate all of chaos's changes)
-            }
-            QudUXTradeUI.ShowTradeScreen(Trader, _costMultiple, (QudUXTradeUI.TradeScreenMode)screenMode);
-            return false; //skip the original function
-        }
-    }
 }

Options.xml

@@ -10,7 +10,6 @@
   <option ID="QudUX_OptionValPerLbInInventory" DisplayText=" In revamped inventory, press {{W|.}} or {{W|0}} to show value per pound" Category="QudUX" Type="Checkbox" Default="Yes"></option>
   <option ID="QudUX_OptionUseCookMenus" DisplayText="Use revamped cooking menus (requires restart)" Category="QudUX" Type="Checkbox" Default="Yes"></option>
   <option ID="QudUX_OptionUseBuildLibrary" DisplayText="Use revamped build library text UI (requires restart)" Category="QudUX" Type="Checkbox" Default="Yes"></option>
-  <option ID="QudUX_OptionCollapseInTradeMenu" DisplayText="Enable collapsible categories on the trade screen text UI" Category="QudUX" Type="Checkbox" Default="Yes"></option>
   <option ID="QudUX_OptionCustomSpriteMenu" DisplayText="Modify your sprite from character creation text UI (requires restart)" Category="QudUX" Type="Checkbox" Default="Yes"></option>
   <option ID="QudUX_OptionTileConversationUI" DisplayText="Show sprites in conversation screen text UI" Category="QudUX" Type="Checkbox" Default="Yes"></option>
   <option ID="QudUX_OptionAbilityDescriptions" DisplayText="Add descriptions and cooldown info to activated ability screen" Category="QudUX" Type="Checkbox" Default="Yes"></option>